Skip to content

Conversation

@svlachakis
Copy link
Contributor

Changes needed for NethermindEth/nethermind-arbitrum#167

In Arbitrum we have Precompiled Addresses that need to be handled by isPrecompile function in AddressExtensions.cs
Since the method is static and we can't put Arbitrum related logic there we need to make this method extensible.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

@svlachakis svlachakis marked this pull request as ready for review August 31, 2025 11:27
Copy link
Contributor

@wurdum wurdum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have it merged directly into the master.

@svlachakis svlachakis changed the base branch from feature/arbitrum-setup to master August 31, 2025 20:33
@svlachakis svlachakis requested review from a team, MarekM25 and rubo as code owners August 31, 2025 20:33
@svlachakis svlachakis changed the base branch from master to feature/arbitrum-setup August 31, 2025 20:33
@svlachakis svlachakis removed request for a team and rubo August 31, 2025 20:34
@svlachakis svlachakis removed the request for review from MarekM25 August 31, 2025 20:34
@LukaszRozmej
Copy link
Member

LukaszRozmej commented Aug 31, 2025

It would be nice to have it merged directly into the master.

true, not sure why it targets branch, this can safely go to master

@svlachakis
Copy link
Contributor Author

PR with master as target #9222 - closing this one & deleting the branch.

@svlachakis svlachakis closed this Sep 1, 2025
@svlachakis svlachakis deleted the precompiles-ireleasespec branch September 1, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants