feat: implement ProgressLogger for Full Pruning, Trie Verification and Analytics operations #9146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdacap
reviewed
Aug 17, 2025
PROGRESS_LOGGER_LOG_SAMPLES.md
Outdated
| @@ -0,0 +1,109 @@ | |||
| # ProgressLogger Log Samples | |||
Contributor
There was a problem hiding this comment.
I mean, put it in the pr descrpition, not committing it.
Author
There was a problem hiding this comment.
I've committed it for the sake of you to review it and tell what you think, and after I was gonna delete it
asdacap
requested changes
Aug 17, 2025
|
|
||
| public void VisitTree(in OldStyleTrieVisitContext _, in ValueHash256 rootHash) | ||
| { | ||
| if (_progressLogger is not null) |
Contributor
There was a problem hiding this comment.
Dont make it optional then. In test, there is LimboLog.
|
|
||
| // For now, we'll use a conservative estimate based on typical state sizes | ||
| // This can be improved with more sophisticated estimation logic | ||
| return 10_000_000; // Conservative estimate for mainnet state |
Contributor
There was a problem hiding this comment.
Do it properly, or don't at all.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8504
Changes
Key Features
Files Modified
ProgressLogger Log Samples
Here are examples of the improved logging output for various operations after implementing ProgressLogger improvements:
Full Pruning Log Samples
Starting Full Pruning:
During Full Pruning (Progress Updates):
Completed Full Pruning:
Trie Verification Log Samples
Starting Trie Verification:
2024-01-15 11:00:00.000 | INFO | Trie Verification Progress: 0 | Speed: 0 nodes/sec | [████████████████████] 0%During Trie Verification:
Completed Trie Verification:
Supply Verification Log Samples
Starting Supply Verification:
2024-01-15 12:00:00.000 | INFO | Supply Verification Progress: 0 | Speed: 0 accounts/sec | [████████████████████] 0%During Supply Verification:
Completed Supply Verification:
Total Difficulty Fix Migration Log Samples
Starting Migration:
2024-01-15 13:00:00.000 | INFO | TotalDifficulty Fix Progress: 0 / 1,000,000 (0.0%) | Speed: 0 blocks/sec | [████████████████████] 0%During Migration:
Completed Migration: