Incorrect Gas Estimation

src/Nethermind/Nethermind.Blockchain/Tracing/GasEstimator.cs

@@ -94,7 +94,7 @@ private long BinarySearchEstimate(long leftBound, long rightBound, Transaction t
             (long)((gasTracer.GasSpent + gasTracer.TotalRefund + GasCostOf.CallStipend) * marginWithDecimals);
         if (optimisticGasEstimate > leftBound && optimisticGasEstimate < rightBound)
         {
-            if (TryExecutableTransaction(tx, header, optimisticGasEstimate, token))
+            if (TryExecutableTransaction(tx, header, optimisticGasEstimate, token, gasTracer))
                 rightBound = optimisticGasEstimate;
             else
                 leftBound = optimisticGasEstimate;
@@ -106,7 +106,7 @@ private long BinarySearchEstimate(long leftBound, long rightBound, Transaction t
                && leftBound + 1 < rightBound)
         {
             long mid = (leftBound + rightBound) / 2;
-            if (!TryExecutableTransaction(tx, header, mid, token))
+            if (!TryExecutableTransaction(tx, header, mid, token, gasTracer))
             {
                 leftBound = mid;
             }
@@ -116,7 +116,7 @@ private long BinarySearchEstimate(long leftBound, long rightBound, Transaction t
             }
         }
 
-        if (rightBound == cap && !TryExecutableTransaction(tx, header, rightBound, token))
+        if (rightBound == cap && !TryExecutableTransaction(tx, header, rightBound, token, gasTracer))
         {
             return 0;
         }
@@ -125,18 +125,16 @@ private long BinarySearchEstimate(long leftBound, long rightBound, Transaction t
     }
 
     private bool TryExecutableTransaction(Transaction transaction, BlockHeader block, long gasLimit,
-        CancellationToken token)
+        CancellationToken token, EstimateGasTracer gasTracer)
     {
-        OutOfGasTracer tracer = new();
-
         Transaction txClone = new Transaction();
         transaction.CopyTo(txClone);
         txClone.GasLimit = gasLimit;
 
         _transactionProcessor.SetBlockExecutionContext(new(block, _specProvider.GetSpec(block)));
-        _transactionProcessor.CallAndRestore(txClone, tracer.WithCancellation(token));
+        TransactionResult result = _transactionProcessor.CallAndRestore(txClone, gasTracer.WithCancellation(token));
 
-        return !tracer.OutOfGas;
+        return result.Success && gasTracer.StatusCode == StatusCode.Success;
     }
 
     private class OutOfGasTracer : TxTracer

src/Nethermind/Nethermind.Evm.Test/Tracing/GasEstimationTests.cs

@@ -403,5 +403,19 @@ public TestEnvironment()
                 estimator = new(_transactionProcessor, _stateProvider, _specProvider, blocksConfig);
             }
         }
+
+        [Test]
+        public void EstimateGasTracer_should_set_status_code_correctly()
+        {
+            EstimateGasTracer tracer = new();
+
+            tracer.MarkAsSuccess(Address.Zero, 25000, [], []);
+            tracer.StatusCode.Should().Be(StatusCode.Success,
+                "MarkAsSuccess should set StatusCode to Success");
+
+            tracer.MarkAsFailed(Address.Zero, 25000, [], "execution reverted");
+            tracer.StatusCode.Should().Be(StatusCode.Failure,
+                "MarkAsFailed should set StatusCode to Failure");
+        }
     }
 }