Skip to content

Unify BN254 naming #9004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubo merged 1 commit into from
Jul 17, 2025
Merged

Unify BN254 naming #9004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Nethermind/Nethermind.Core/Specs/IReleaseSpec.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ public interface IReleaseSpec : IEip1559Spec, IReceiptSpec

public bool ModExpEnabled => IsEip198Enabled;

public bool Bn128Enabled => IsEip196Enabled && IsEip197Enabled;
public bool BN254Enabled => IsEip196Enabled && IsEip197Enabled;

public bool BlakeEnabled => IsEip152Enabled;

Expand Down
2 changes: 1 addition & 1 deletion src/Nethermind/Nethermind.Core/Specs/ReleaseSpecDecorator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ public class ReleaseSpecDecorator(IReleaseSpec spec) : IReleaseSpec
public virtual bool UseTxAccessLists => spec.UseTxAccessLists;
public virtual bool AddCoinbaseToTxAccessList => spec.AddCoinbaseToTxAccessList;
public virtual bool ModExpEnabled => spec.ModExpEnabled;
public virtual bool Bn128Enabled => spec.Bn128Enabled;
public virtual bool BN254Enabled => spec.BN254Enabled;
public virtual bool BlakeEnabled => spec.BlakeEnabled;
public virtual bool Bls381Enabled => spec.Bls381Enabled;
public virtual bool ChargeForTopLevelCreate => spec.ChargeForTopLevelCreate;
Expand Down
2 changes: 1 addition & 1 deletion src/Nethermind/Nethermind.Evm.Precompiles/Extensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public static OrderedDictionary<Address, string> ListPrecompiles(this IReleaseSp
AddPrecompile<ModExpPrecompile>();
}

if (spec.Bn128Enabled)
if (spec.BN254Enabled)
{
AddPrecompile<BN254AddPrecompile>();
AddPrecompile<BN254MulPrecompile>();
Expand Down
6 changes: 3 additions & 3 deletions src/Nethermind/Nethermind.Evm/Precompiles/AddressExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ public static bool IsPrecompile(this Address address, IReleaseSpec releaseSpec)
0x03 => true,
0x04 => true,
0x05 => releaseSpec.ModExpEnabled,
0x06 => releaseSpec.Bn128Enabled,
0x07 => releaseSpec.Bn128Enabled,
0x08 => releaseSpec.Bn128Enabled,
0x06 => releaseSpec.BN254Enabled,
0x07 => releaseSpec.BN254Enabled,
0x08 => releaseSpec.BN254Enabled,
0x09 => releaseSpec.BlakeEnabled,
0x0a => releaseSpec.IsEip4844Enabled,
0x0b => releaseSpec.Bls381Enabled,
Expand Down