Skip to content

Update CLZ gas cost for devnet3 #8953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benaadams merged 1 commit into from
Jul 10, 2025
Merged

Update CLZ gas cost for devnet3 #8953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Nethermind/Nethermind.Evm/Instructions/EvmInstructions.Math1Param.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@ public struct OpIsZero : IOpMath1Param
/// </summary>
public struct OpCLZ : IOpMath1Param
{
Copy link

Copilot AI Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GasCost property lacks documentation explaining the gas cost value and its relation to the EIP-9987 specification change from 3 to 5 gas units.

Suggested change
{
{
/// <summary>
/// Gas cost for the CLZ (Count Leading Zeros) operation.
/// Updated to 5 gas units as per EIP-9987, which increased the cost from the previous value of 3 gas units.
/// </summary>

Copilot uses AI. Check for mistakes.
static long GasCost => GasCostOf.Low;

public static Word Operation(Word value) => value == default
? Vector256.Create((byte)0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0)
: Vector256.Create(0UL, 0UL, 0UL, (ulong)value.CountLeadingZeroBits() << 56).AsByte();
Expand Down