Refactor/make pre warmer worldstate agnostic#7109
Merged
Conversation
Member
LukaszRozmej
left a comment
LukaszRozmej
left a comment
There was a problem hiding this comment.
I have mixed feelings, we are bloating IWorldState and kind of hide a bit the intention of the hashes.
Contributor
Author
|
We should hide it. A different state db might not even have rlp encoding at all. |
src/Nethermind/Nethermind.Consensus/Processing/BlockCachePreWarmer.cs
Outdated
Show resolved
Hide resolved
LukaszRozmej
approved these changes
Jun 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes