Skip to content

Fix NPE on aura plugin #7031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asdacap merged 2 commits into from
May 16, 2024
Merged

Fix NPE on aura plugin #7031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13b7248
Fix NP on aura plugin
asdacap May 16, 2024
8b7c8cf
Fix test
asdacap May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Nethermind/Nethermind.AuRa.Test/AuRaPluginTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using Nethermind.Api;
using Nethermind.Config;
using Nethermind.Consensus.AuRa;
using Nethermind.Consensus.AuRa.InitializationSteps;
using Nethermind.Logging;
using Nethermind.Serialization.Json;
using Nethermind.Specs.ChainSpecStyle;
Expand All @@ -19,7 +20,7 @@ public class AuRaPluginTests
public void Init_when_not_AuRa_doesnt_trow()
{
AuRaPlugin auRaPlugin = new();
Action init = () => auRaPlugin.Init(new NethermindApi(new ConfigProvider(), new EthereumJsonSerializer(), new TestLogManager(), new ChainSpec()));
Action init = () => auRaPlugin.Init(new AuRaNethermindApi(new ConfigProvider(), new EthereumJsonSerializer(), new TestLogManager(), new ChainSpec()));
init.Should().NotThrow();
}

Expand Down
2 changes: 1 addition & 1 deletion src/Nethermind/Nethermind.Consensus.AuRa/AuRaPlugin.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ public ValueTask DisposeAsync()
public Task Init(INethermindApi nethermindApi)
{
_nethermindApi = nethermindApi as AuRaNethermindApi;
_blockProducerStarter = new(_nethermindApi);
return Task.CompletedTask;
}

Expand Down Expand Up @@ -69,7 +70,6 @@ public Task<IBlockProducer> InitBlockProducer(ITxSource? additionalTxSource = nu
{
if (_nethermindApi is not null)
{
_blockProducerStarter = new(_nethermindApi);
return _blockProducerStarter!.BuildProducer(additionalTxSource);
}

Expand Down