Use existing array for precompile result

[benaadams]

Changes

• Use existing array for precompile result, when Memory array backed and size same

Types of changes

What types of changes does your code introduce?

• Optimization

Testing

Requires testing

• No

[benaadams]

Not enturely sure why, but IdentityPrecompile isn't really used so shouldn't really matter

[LukaszRozmej]

Also would it be better to be bool TryRun(in ReadOnlyMemory<byte> inputData, IReleaseSpec releaseSpec, out ReadOnlyMemory<byte> result) ?

[benaadams]

Also would it be better to be bool TryRun(in ReadOnlyMemory<byte> inputData, IReleaseSpec releaseSpec, out ReadOnlyMemory<byte> result) ?

More of a break if another chain has their own precompiles? (Don't know if they do)

[LukaszRozmej]

Also would it be better to be bool TryRun(in ReadOnlyMemory<byte> inputData, IReleaseSpec releaseSpec, out ReadOnlyMemory<byte> result) ?

More of a break if another chain has their own precompiles? (Don't know if they do)

huh why? I am askung about just changing interface, bool can go via register, or the whole tuple goes via registers?

[benaadams]

Also would it be better to be bool TryRun(in ReadOnlyMemory<byte> inputData, IReleaseSpec releaseSpec, out ReadOnlyMemory<byte> result) ?

More of a break if another chain has their own precompiles? (Don't know if they do)

huh why? I am askung about just changing interface, bool can go via register, or the whole tuple goes via registers?

I mean if any existing extenal precompiles/plugin as they would need to change their signiture to upgrade?

[benaadams]

Would be a better signiture though :)

[LukaszRozmej]

Also would it be better to be bool TryRun(in ReadOnlyMemory<byte> inputData, IReleaseSpec releaseSpec, out ReadOnlyMemory<byte> result) ?

More of a break if another chain has their own precompiles? (Don't know if they do)

huh why? I am askung about just changing interface, bool can go via register, or the whole tuple goes via registers?

I mean if any existing extenal precompiles/plugin as they would need to change their signiture to upgrade?

I don't think there are any, and if yes this is trivial change