Skip to content

Eip4788 : Update address and buffer size (Post audit) #6098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarekM25 merged 1 commit into from
Sep 15, 2023
Merged

Eip4788 : Update address and buffer size (Post audit) #6098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Nethermind/Nethermind.Blockchain/BeaconBlockRoot/BeaconBlockRootHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
namespace Nethermind.Consensus.BeaconBlockRoot;
public class BeaconBlockRootHandler : IBeaconBlockRootHandler
{
public static UInt256 HISTORICAL_ROOTS_LENGTH = 98304;
private static readonly Address DefaultPbbrContractAddress = new Address("0xbEac00dDB15f3B6d645C48263dC93862413A222D");
public static UInt256 HISTORICAL_ROOTS_LENGTH = 8191;
Copy link
Contributor

@MarekM25 MarekM25 Sep 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oO big change from 98304 to 8191

Copy link
Contributor Author

@Demuirgos Demuirgos Sep 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, I wonder why
edit : from Pr ethereum/EIPs#7672 (comment)

private static readonly Address DefaultPbbrContractAddress = new Address("0xbEaC02001Aedb23b4088c853e4C05c57491c8bCA");

public void ApplyContractStateChanges(Block block, IReleaseSpec spec, IWorldState stateProvider)
{
Expand Down