Skip to content

Comments

Made precompile address property static#5920

Merged
Demuirgos merged 2 commits intomasterfrom
Refactor/Evm/PreompileAddressAccessModifer
Jul 11, 2023
Merged

Made precompile address property static#5920
Demuirgos merged 2 commits intomasterfrom
Refactor/Evm/PreompileAddressAccessModifer

Conversation

@Demuirgos
Copy link
Contributor

Fixes Closes Resolves #

Please choose one of the keywords above to refer to the issue this PR solves followed by the issue number (e.g. Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Remove this note after reading.

Changes

  • changed Precompile.Address from an instance property to be static

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

@Demuirgos Demuirgos requested review from MarekM25, benaadams and rubo July 10, 2023 23:22
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like same thing was done in #5476

public interface IPrecompile
{
Address Address { get; }
static Address Address { get; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that you can have statics in interfaces now

@Demuirgos Demuirgos changed the title - made precompile address static Made precompile address static Jul 11, 2023
@Demuirgos Demuirgos changed the title Made precompile address static Made precompile address property static Jul 11, 2023
@Demuirgos Demuirgos merged commit 43660b6 into master Jul 11, 2023
@Demuirgos Demuirgos deleted the Refactor/Evm/PreompileAddressAccessModifer branch July 11, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants