Skip to content

Fix point evaluation precompile #5739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flcl42 merged 7 commits into from
May 31, 2023
Merged

Fix point evaluation precompile #5739

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
17d5694
Fix
May 29, 2023
4883d84
Fix test
May 29, 2023
91e67e2
z & y to big endian
May 29, 2023
06a8727
SkipLocalsInit
May 29, 2023
49ddef0
Update bindings version
May 30, 2023
28b0971
Update the trusted setup
flcl42 May 30, 2023
3acf108
Speed up a method with SkipLocalsInit
flcl42 May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
133 changes: 119 additions & 14 deletions src/Nethermind/Nethermind.Evm.Test/PointEvaluationPrecompileTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ namespace Nethermind.Evm.Test;
public class PointEvaluationPrecompileTests
{
private static readonly byte[] _predefinedSuccessAnswer =
Bytes.FromHexString("001000000000000001000000fffffffffe5bfeff02a4bd5305d8a10908d83933487d9d2953a7ed73");
Bytes.FromHexString("000000000000000000000000000000000000000000000000000000000000100073eda753299d7d483339d80809a1d80553bda402fffe5bfeffffffff00000001");

private static readonly byte[] _predefinedFailureAnswer = Array.Empty<byte>();

Expand Down Expand Up @@ -64,48 +64,153 @@ public void Test_PointEvaluationPrecompile_Has_Specific_Constant_Gas_Cost(byte[]

public static IEnumerable<TestCaseData> GasTests => InvalidTestCases.Union(ValidTestCases);

private static byte[] CreateKzgTestInput(string versionedHash, string z, string y, string commitment, string proof)
{
versionedHash.Length.Should().Be(64);
z.Length.Should().Be(64);
y.Length.Should().Be(64);
commitment.Length.Should().Be(96);
proof.Length.Should().Be(96);
return Bytes.FromHexString(versionedHash + z + y + commitment + proof);
}

private static IEnumerable<TestCaseData> InvalidTestCases
{
get
{
yield return new TestCaseData(Bytes.FromHexString("00")) { TestName = "Incorrect data size - 2" };
yield return new TestCaseData(Array.Empty<byte>()) { TestName = "Incorrect data size - 0" };
yield return new TestCaseData(Bytes.FromHexString(
"ff0657f37554c781402a22917dee2f75def7ab966d7b770905398eba3c44401400000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"))
yield return new TestCaseData(CreateKzgTestInput(
"ff0657f37554c781402a22917dee2f75def7ab966d7b770905398eba3c444014",
"0000000000000000000000000000000000000000000000000000000000000000",
"0000000000000000000000000000000000000000000000000000000000000000",
"c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
"c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"))
{
TestName = "Hash is not correctly versioned"
};
yield return new TestCaseData(Bytes.FromHexString(
"010657f37554c781402a22917dee2f75def7ab966d7b770905398eba3c44401400000000000000000000000000000000000000000000000000000000000000ff0000000000000000000000000000000000000000000000000000000000000000c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"))
yield return new TestCaseData(CreateKzgTestInput(
"010657f37554c781402a22917dee2f75def7ab966d7b770905398eba3c444014",
"ff00000000000000000000000000000000000000000000000000000000000000",
"0000000000000000000000000000000000000000000000000000000000000000",
"c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
"c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"))
{
TestName = "Z is out of range"
};
yield return new TestCaseData(Bytes.FromHexString(
"010657f37554c781402a22917dee2f75def7ab966d7b770905398eba3c444014000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000ffc00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"))
yield return new TestCaseData(CreateKzgTestInput(
"010657f37554c781402a22917dee2f75def7ab966d7b770905398eba3c444014",
"0000000000000000000000000000000000000000000000000000000000000000",
"ff00000000000000000000000000000000000000000000000000000000000000",
"c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
"c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"))
{
TestName = "Y is out of range"
};
yield return new TestCaseData(Bytes.FromHexString(
"010657f37554c781402a22917dee2f75def7ab966d7b770905398eba3c44401400000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c10000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"))
yield return new TestCaseData(CreateKzgTestInput(
"010657f37554c781402a22917dee2f75def7ab966d7b770905398eba3c444014",
"0000000000000000000000000000000000000000000000000000000000000000",
"0000000000000000000000000000000000000000000000000000000000000000",
"c10000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
"c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"))
{

TestName = "Commitment does not much hash"
};
yield return new TestCaseData(Bytes.FromHexString(
"010657f37554c781402a22917dee2f75def7ab966d7b770905398eba3c44401400000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c20000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"))
yield return new TestCaseData(CreateKzgTestInput(
"010657f37554c781402a22917dee2f75def7ab966d7b770905398eba3c444014",
"0000000000000000000000000000000000000000000000000000000000000000",
"0000000000000000000000000000000000000000000000000000000000000000",
"c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
"c20000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"))
{
TestName = "Proof does not match"
};

yield return new TestCaseData(CreateKzgTestInput(
"01d18459b334ffe8e2226eef1db874fda6db2bdd9357268b39220af2d59464fb",
"5eb7004fe57383e6c88b99d839937fddf3f99279353aaf8d5c9a75f91ce33c62",
"4882cf0609af8c7cd4c256e63a35838c95a9ebbf6122540ab344b42fd66d32e1",
"978a0d595c823c05947b1156175e72634a377808384256e9921ebf72181890be2d6b58d4a73a880541d1656875654806",
"95c51f028ec8ace94b2c24fff6662e4c61ad7b315b799aa5f40fcf5b36b2f1b6f9fc23bc66290aeef1de7e6ee4cb52ce"))
{
TestName = "Incorrect proof 1"
};

yield return new TestCaseData(CreateKzgTestInput(
"01d18459b334ffe8e2226eef1db874fda6db2bdd9357268b39220af2d59464fb",
"73eda753299d7d483339d80809a1d80553bda402fffe5bfeffffffff00000000",
"1522a4a7f34e1ea350ae07c29c96c7e79655aa926122e95fe69fcbd932ca49e9",
"978a0d595c823c05947b1156175e72634a377808384256e9921ebf72181890be2d6b58d4a73a880541d1656875654806",
"9418eb9a7cf2fa71125962f6662afeac10a7f1bbe26365995b13f6840946da49f79c7dfdd80b5b8a50bf44758cd2a96d"))
{
TestName = "Incorrect proof 2"
};
}
}

private static IEnumerable<TestCaseData> ValidTestCases
{
get
{
yield return new TestCaseData(Bytes.FromHexString(
"010657f37554c781402a22917dee2f75def7ab966d7b770905398eba3c44401400000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"))
yield return new TestCaseData(CreateKzgTestInput(
"010657f37554c781402a22917dee2f75def7ab966d7b770905398eba3c444014",
"0000000000000000000000000000000000000000000000000000000000000000",
"0000000000000000000000000000000000000000000000000000000000000000",
"c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
"c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"))
{
TestName = "Verification passes 1"
};

yield return new TestCaseData(CreateKzgTestInput(
"010657f37554c781402a22917dee2f75def7ab966d7b770905398eba3c444014",
"5eb7004fe57383e6c88b99d839937fddf3f99279353aaf8d5c9a75f91ce33c62",
"0000000000000000000000000000000000000000000000000000000000000000",
"c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
"c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"))
{
TestName = "Verification passes 2"
};

yield return new TestCaseData(CreateKzgTestInput(
"010657f37554c781402a22917dee2f75def7ab966d7b770905398eba3c444014",
"0000000000000000000000000000000000000000000000000000000000000001",
"0000000000000000000000000000000000000000000000000000000000000000",
"c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
"c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"))
{
TestName = "Verification passes 3"
};

yield return new TestCaseData(CreateKzgTestInput(
"010657f37554c781402a22917dee2f75def7ab966d7b770905398eba3c444014",
"564c0a11a0f704f4fc3e8acfe0f8245f0ad1347b378fbf96e206da11a5d36306",
"0000000000000000000000000000000000000000000000000000000000000000",
"c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
"c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"))
{
TestName = "Verification passes 4"
};

yield return new TestCaseData(CreateKzgTestInput(
"010657f37554c781402a22917dee2f75def7ab966d7b770905398eba3c444014",
"0000000000000000000000000000000000000000000000000000000000000002",
"0000000000000000000000000000000000000000000000000000000000000000",
"c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000",
"c00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"))
{
TestName = "Verification passes 5"
};

yield return new TestCaseData(CreateKzgTestInput(
"01d18459b334ffe8e2226eef1db874fda6db2bdd9357268b39220af2d59464fb",
"564c0a11a0f704f4fc3e8acfe0f8245f0ad1347b378fbf96e206da11a5d36306",
"24d25032e67a7e6a4910df5834b8fe70e6bcfeeac0352434196bdf4b2485d5a1",
"978a0d595c823c05947b1156175e72634a377808384256e9921ebf72181890be2d6b58d4a73a880541d1656875654806",
"942307f266e636553e94006d11423f2688945ff3bdf515859eba1005c1a7708d620a94d91a1c0c285f9584e75ec2f82a"))
{
TestName = "Verification passes"
TestName = "Verification passes 6"
};
}
}
Expand Down
15 changes: 10 additions & 5 deletions src/Nethermind/Nethermind.Evm/Precompiles/PointEvaluationPrecompile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
using Nethermind.Core;
using Nethermind.Core.Specs;
using Nethermind.Crypto;
using Nethermind.Int256;

namespace Nethermind.Evm.Precompiles;

Expand All @@ -15,9 +16,9 @@ public class PointEvaluationPrecompile : IPrecompile
public static readonly IPrecompile Instance = new PointEvaluationPrecompile();

private static readonly ReadOnlyMemory<byte> PointEvaluationSuccessfulResponse =
BitConverter.GetBytes((long)Ckzg.Ckzg.FieldElementsPerBlob)
.Concat(KzgPolynomialCommitments.BlsModulus.ToLittleEndian())
.ToArray();
((UInt256)Ckzg.Ckzg.FieldElementsPerBlob).ToBigEndian()
.Concat(KzgPolynomialCommitments.BlsModulus.ToBigEndian())
.ToArray();

public Address Address { get; } = Address.FromNumber(0x14);

Expand All @@ -37,8 +38,12 @@ static bool IsValid(in ReadOnlyMemory<byte> inputData)

ReadOnlySpan<byte> inputDataSpan = inputData.Span;
ReadOnlySpan<byte> versionedHash = inputDataSpan[..32];
ReadOnlySpan<byte> z = inputDataSpan[32..64];
ReadOnlySpan<byte> y = inputDataSpan[64..96];
Span<byte> z = stackalloc byte[32];
Comment thread
flcl42 marked this conversation as resolved.
Outdated
inputDataSpan[32..64].CopyTo(z);
z.Reverse();
Span<byte> y = stackalloc byte[32];
inputDataSpan[64..96].CopyTo(y);
y.Reverse();
ReadOnlySpan<byte> commitment = inputDataSpan[96..144];
ReadOnlySpan<byte> proof = inputDataSpan[144..192];
Span<byte> hash = stackalloc byte[32];
Expand Down