Skip to content

Fixes for 4884 tests in hive: simulators/eth/pyspec#5658

Closed
spencer-tb wants to merge 4 commits intoNethermindEth:feature/eip-4844-v5from
spencer-tb:genesis-4844-syncing-fix
Closed

Fixes for 4884 tests in hive: simulators/eth/pyspec#5658
spencer-tb wants to merge 4 commits intoNethermindEth:feature/eip-4844-v5from
spencer-tb:genesis-4844-syncing-fix

Conversation

@spencer-tb
Copy link

Adds some small changes required to get all our current 4844 execution-spec-tests to pass within the pyspec hive simulator. This simulator simply runs all of our fixtures against clients using the EngineAPI. More info on how to run it below within "Notes on testing".

Changes

  • Skips the ExcessDataGas calculation within BlockProcessor for genesis blocks, where the block number is zero (prevents SYNCING).
  • Updates the ChainSpec to use the ExcessDataGas field input from the genesis block as opposed to using a value of zero (prevents SYNCING).
  • Moves the KZG hash version check from the transaction execution payload validation step into the transaction network validation step within TxValidator (prevents VALID payloads being recognized as INVALID).

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

This has not been tested internally within Nethermind.

These changes allow all of our 4844 execution-spec-tests to pass on hive using the pyspec simulator. If you want to try it out yourself you can use this testing branch -> here.

Note that the branch is experimental for the time being but you should be able to run the tests by 1) re-building hive after pulling in the changes, 2) using the following command:

./hive --sim ethereum/pyspec --client "./nethermind.json" --docker.nocache nethermind --sim.limit /4844

@spencer-tb spencer-tb marked this pull request as ready for review May 5, 2023 14:14
@flcl42 flcl42 force-pushed the feature/eip-4844-v5 branch from 1bddf40 to f856ff5 Compare May 9, 2023 15:47
@flcl42 flcl42 requested a review from a team as a code owner May 9, 2023 15:47
@spencer-tb spencer-tb force-pushed the genesis-4844-syncing-fix branch from 46977bf to e1bb9d0 Compare May 9, 2023 17:38
@spencer-tb spencer-tb closed this May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments