Fixes for 4884 tests in hive: simulators/eth/pyspec#5658
Closed
spencer-tb wants to merge 4 commits intoNethermindEth:feature/eip-4844-v5from
Closed
Fixes for 4884 tests in hive: simulators/eth/pyspec#5658spencer-tb wants to merge 4 commits intoNethermindEth:feature/eip-4844-v5from
simulators/eth/pyspec#5658spencer-tb wants to merge 4 commits intoNethermindEth:feature/eip-4844-v5from
Conversation
1bddf40 to
f856ff5
Compare
46977bf to
e1bb9d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some small changes required to get all our current 4844
execution-spec-teststo pass within thepyspechive simulator. This simulator simply runs all of our fixtures against clients using the EngineAPI. More info on how to run it below within "Notes on testing".Changes
BlockProcessorfor genesis blocks, where the block number is zero (prevents SYNCING).ChainSpecto use the ExcessDataGas field input from the genesis block as opposed to using a value of zero (prevents SYNCING).TxValidator(prevents VALID payloads being recognized as INVALID).Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
This has not been tested internally within Nethermind.
These changes allow all of our 4844
execution-spec-teststo pass on hive using thepyspecsimulator. If you want to try it out yourself you can use this testing branch -> here.Note that the branch is experimental for the time being but you should be able to run the tests by 1) re-building hive after pulling in the changes, 2) using the following command:
./hive --sim ethereum/pyspec --client "./nethermind.json" --docker.nocache nethermind --sim.limit /4844