engine: return -38003 for FCUv2 payloadAttributes mismatch#10770
Closed
Muzry wants to merge 1 commit into
Closed
Conversation
3 tasks
Member
|
closing in favor of #10786 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
engine_forkchoiceUpdatedV2to return-38003: Invalid payload attributeswhen the wrongpayloadAttributesversion is used.In particular, FCUv2 payload-attribute version mismatches such as:
withdrawalsat or after Shanghaiwithdrawalsbefore Shanghaishould be treated as
Invalid payload attributes, notInvalid params.Why
This change aligns the client with the latest Engine API spec update in:
It also follows the implementation discussion and prior client-side change in:
The spec was clarified so that FCUv2 now behaves consistently with newer forkchoiceUpdated versions for payloadAttributes structure/version
mismatches.
What changed
-38003for payloadAttributes version mismatches.Hive impact
This fixes the Hive
engine-withdrawalsfailure caused by returning the wrong error code for FCUv2 payloadAttributes mismatches.Relevant Hive failure:
After this change, the client returns the expected error code for the affected FCUv2 cases.
If my understanding or interpretation of the spec change is incorrect, please let me know and I can adjust the implementation accordingly.