Skip to content

fix: clear reference-type elements in Truncate to prevent pool memory leak #10472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukaszRozmej merged 3 commits into from
Feb 11, 2026
Merged

fix: clear reference-type elements in Truncate to prevent pool memory leak #10472

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c1cbb7
fix: clear reference-type elements in Truncate to prevent pool memory…
phrwlk Feb 9, 2026
019539b
add helper
phrwlk Feb 10, 2026
8fa7737
Merge branch 'master' into fix/truncate-reference-leak
LukaszRozmej Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/Nethermind/Nethermind.Core/Collections/ArrayListCore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,15 @@ public static void ClearToCount(T[] array, int count)
}
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
private static void ClearTail(T[] array, int newCount, int oldCount)
{
if (RuntimeHelpers.IsReferenceOrContainsReferences<T>() && newCount < oldCount)
{
Array.Clear(array, newCount, oldCount - newCount);
}
}

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static void Add(
ArrayPool<T> pool,
Expand Down Expand Up @@ -108,9 +117,9 @@ public static void ReduceCount(
ClearToCount(oldArray, oldCount);
pool.Return(oldArray);
}
else if (RuntimeHelpers.IsReferenceOrContainsReferences<T>())
else
{
Array.Clear(array, newCount, oldCount - newCount);
ClearTail(array, newCount, oldCount);
}

[DoesNotReturn]
Expand Down Expand Up @@ -228,6 +237,7 @@ public static void Insert(
public static void Truncate(int newLength, T[] array, ref int count)
{
GuardIndex(newLength, count, shouldThrow: true, allowEqualToCount: true);
ClearTail(array, newLength, count);
count = newLength;
}

Expand Down