Skip to content

Align tx sending error code #10464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flcl42 merged 2 commits into from
Feb 10, 2026
Merged

Align tx sending error code #10464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48e86a9
Align tx sending error code
flcl42 Feb 9, 2026
c9be96c
Merge branch 'master' into error-code
flcl42 Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Nethermind/Nethermind.JsonRpc.Test/Modules/Eth/EthRpcModuleTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1173,7 +1173,7 @@ public async Task Send_raw_transaction_will_send_transaction(string rawTransacti
string serialized = await ctx.Test.TestEthRpc("eth_sendRawTransaction", rawTransaction);
Transaction tx = Rlp.Decode<Transaction>(Bytes.FromHexString(rawTransaction));
await txSender.Received().SendTransaction(tx, TxHandlingOptions.PersistentBroadcast);
Assert.That(serialized, Is.EqualTo("{\"jsonrpc\":\"2.0\",\"error\":{\"code\":-32010,\"message\":\"Invalid, InvalidTxSignature: Signature is invalid.\"},\"id\":67}"));
Assert.That(serialized, Is.EqualTo("{\"jsonrpc\":\"2.0\",\"error\":{\"code\":-32000,\"message\":\"Invalid, InvalidTxSignature: Signature is invalid.\"},\"id\":67}"));
}

[Test]
Expand Down Expand Up @@ -1224,7 +1224,7 @@ public async Task Send_transaction_should_return_ErrorCode_if_tx_not_added()

string serialized = await ctx.Test.TestEthRpc("eth_sendTransaction", txForRpc);

Assert.That(serialized, Is.EqualTo("{\"jsonrpc\":\"2.0\",\"error\":{\"code\":-32010,\"message\":\"InsufficientFunds, Balance is zero, cannot pay gas\"},\"id\":67}"));
Assert.That(serialized, Is.EqualTo("{\"jsonrpc\":\"2.0\",\"error\":{\"code\":-32000,\"message\":\"InsufficientFunds, Balance is zero, cannot pay gas\"},\"id\":67}"));
}

public enum AccessListProvided
Expand Down
8 changes: 4 additions & 4 deletions src/Nethermind/Nethermind.JsonRpc/ErrorCodes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,14 @@ public static class ErrorCodes
public const int ResourceNotFound = -32000;

/// <summary>
/// Requested resource not available
/// Transaction creation failed
/// </summary>
public const int ResourceUnavailable = -32002;
public const int TransactionRejected = -32000;

/// <summary>
/// Transaction creation failed
/// Requested resource not available
/// </summary>
public const int TransactionRejected = -32010;
public const int ResourceUnavailable = -32002;

/// <summary>
/// Account locked
Expand Down