refactor: additional unused code cleanup (Phase 1)#10444
Closed
smartprogrammer93 wants to merge 1 commit intoNethermindEth:refactoring/unused-codefrom
Closed
refactor: additional unused code cleanup (Phase 1)#10444smartprogrammer93 wants to merge 1 commit intoNethermindEth:refactoring/unused-codefrom
smartprogrammer93 wants to merge 1 commit intoNethermindEth:refactoring/unused-codefrom
Conversation
- Delete 5 empty (0-byte) files in TxPool and Consensus - Remove 7 unused private methods: - TrieStore.IsStillNeeded() - PatriciaTree.ThrowInvalidDataException/ThrowMissingChildException/ThrowMissingPrefixException - EthereumRunner.Stop() - EthereumL1Bridge.LogReorg() - Ssz.DecodeDynamicOffset() (moved VarOffsetSize to BasicTypes.cs) - Remove 7 unused private/static fields: - TrieNode._nodeDecoder - PatriciaTree._singleByteKeys - PersistentStorageProvider._loadFromTreeStorageFunc - SmallTrieVisitContext._branchChildIndex - TdxsClient._logger - InitializeBlockchain._logManager - SyncProgressResolver._logger - Remove 6 dead NDM/LES timeout constants from Timeouts.cs - Remove 11 unused/duplicate ErrorCodes constants - Remove 3 unused L1 epoch constants from EthereumL1Bridge - Clean up unused using directives (System.IO, System)
smartprogrammer93
requested review from
LukaszRozmej,
Marchhill,
MarekM25,
ak88,
asdacap,
benaadams,
damian-orzechowski,
deffrian,
dipkakwani,
emlautarom1,
flcl42 and
marcindsobczak
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Unused Code Cleanup
Building on top of #10440, this PR removes more unused code found via automated analysis across the full codebase.
Changes
5 empty (0-byte) files deleted:
TxNonceTxPoolReserveSealer.cs,TxPool.NonceInfo.cs(TxPool)OverridableTxProcessingScope.cs,IOverridableTxProcessorSource.cs,IOverridableTxProcessingScope.cs(Consensus)7 unused private methods removed:
TrieStore.IsStillNeeded()— dead wrapperPatriciaTree.ThrowInvalidDataException/ThrowMissingChildException/ThrowMissingPrefixException— unused throw helpersEthereumRunner.Stop()— replaced by ServiceStopper patternEthereumL1Bridge.LogReorg()— never calledSsz.DecodeDynamicOffset()— never called (movedVarOffsetSizeto BasicTypes.cs)7 unused fields removed:
TrieNode._nodeDecoder— static instance, all calls use static methodsPatriciaTree._singleByteKeys— unused byte arrayPersistentStorageProvider._loadFromTreeStorageFunc— delegate never invokedSmallTrieVisitContext._branchChildIndex— no accessor, never readTdxsClient._logger— assigned but never readInitializeBlockchain._logManager— assigned but never referencedSyncProgressResolver._logger— assigned but never read6 dead NDM/LES timeout constants removed from
Timeouts.cs(NDM and LES protocols were removed long ago)11 unused/duplicate ErrorCodes constants removed
3 dead L1 epoch constants removed from
EthereumL1BridgeUnused
usingdirectives cleaned up where removal of dead code made them unnecessary