Draft
Conversation
asdacap
force-pushed
the
flat/snap-sync
branch
3 times, most recently
from
4e0cd11 to
ecd1d6b
Compare
asdacap
commented
Feb 8, 2026
| return rlp is not null && ValueKeccak.Compute(rlp) == keccak; | ||
| } | ||
|
|
||
| public void Clear() => _tree.RootHash = Keccak.EmptyTreeHash; |
Contributor
Author
There was a problem hiding this comment.
Clear not needed anymore.
asdacap
commented
Feb 8, 2026
| public void BulkSet(in ArrayPoolListRef<PatriciaTree.BulkSetEntry> entries, PatriciaTree.Flags flags) => | ||
| _tree.BulkSet(entries, flags); | ||
|
|
||
| public void UpdateRootHash() => _tree.UpdateRootHash(); |
Contributor
Author
There was a problem hiding this comment.
Can be embedded as part of BulkSet.
asdacap
commented
Feb 8, 2026
| public class FlatSnapTrieFactory(IPersistence persistence, ILogManager logManager) : ISnapTrieFactory | ||
| { | ||
| private ILogger _logger = logManager.GetClassLogger<FlatSnapTrieFactory>(); | ||
| private bool _databaseInitiallyCleared = false; |
Contributor
Author
There was a problem hiding this comment.
Probably should be "_initialized".
asdacap
commented
Feb 8, 2026
| } | ||
| } | ||
|
|
||
| public Hash256? ResolveStorageRoot(byte[] nodeData) |
Contributor
Author
There was a problem hiding this comment.
Does not need to have different implementation between snap and patricia tree.
Squashed commits: - Parallelize FlatTrieVerifier with partition-based verification - Snap trie store and factory implementation - Tree sync abstraction and store implementation - Snap server and provider helper - Key deletion logic and tests - Inline node handling and verifier fixes - E2E fixes and sync hook - Storage range split support - Interface reduction and cleanup Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
asdacap
commented
Feb 9, 2026
| } | ||
|
|
||
| [Test] | ||
| public void WriteAccountFlatEntries_BranchAndExtension_WithHashReferences_WritesNothing() |
Contributor
Author
There was a problem hiding this comment.
Extensioon cannot have child leaf
asdacap
force-pushed
the
flat/snap-sync
branch
from
79d5068 to
bd90308
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Closes Resolves #
Please choose one of the keywords above to refer to the issue this PR solves followed by the issue number (e.g. Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Remove this note after reading.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.