Fixes 4 flaky test + refactors dbs

src/Nethermind/Nethermind.Blockchain.Test/BeaconBlockRootHandlerTests.cs

@@ -17,6 +17,8 @@
 
 namespace Nethermind.Blockchain.Test;
 
+[Parallelizable(ParallelScope.All)]
+[FixtureLifeCycle(LifeCycle.InstancePerTestCase)]
 public class BeaconBlockRootHandlerTests
 {
     private BeaconBlockRootHandler _beaconBlockRootHandler;

src/Nethermind/Nethermind.Blockchain.Test/BlockFinderExtensionsTests.cs

@@ -11,6 +11,7 @@
 
 namespace Nethermind.Blockchain.Test;
 
+[Parallelizable(ParallelScope.All)]
 public class BlockFinderExtensionsTests
 {
     [Test, MaxTime(Timeout.MaxTestTime)]

src/Nethermind/Nethermind.Blockchain.Test/BlockProcessorTests.cs

@@ -36,6 +36,7 @@
 
 namespace Nethermind.Blockchain.Test;
 
+[Parallelizable(ParallelScope.All)]
 public class BlockProcessorTests
 {
     [Test, MaxTime(Timeout.MaxTestTime)]

src/Nethermind/Nethermind.Blockchain.Test/BlockTreeSuggestPacerTests.cs

@@ -10,6 +10,7 @@
 
 namespace Nethermind.Blockchain.Test;
 
+[Parallelizable(ParallelScope.All)]
 public class BlockTreeSuggestPacerTests
 {
     [Test]

src/Nethermind/Nethermind.Blockchain.Test/BlockTreeTests.cs

@@ -32,6 +32,8 @@
 
 namespace Nethermind.Blockchain.Test;
 
+[Parallelizable(ParallelScope.All)]
+[FixtureLifeCycle(LifeCycle.InstancePerTestCase)]
 public class BlockTreeTests
 {
     private TestMemDb _blocksInfosDb = null!;

src/Nethermind/Nethermind.Blockchain.Test/BlockchainProcessorTests.cs

@@ -28,7 +28,8 @@
 
 namespace Nethermind.Blockchain.Test;
 
-[Parallelizable(ParallelScope.Self)]
+[Parallelizable(ParallelScope.All)]
+[FixtureLifeCycle(LifeCycle.InstancePerTestCase)]
 public class BlockchainProcessorTests
 {
     private class ProcessingTestContext

src/Nethermind/Nethermind.Blockchain.Test/Blocks/BadBlockStoreTests.cs

@@ -12,6 +12,7 @@
 
 namespace Nethermind.Blockchain.Test.Blocks;
 
+[Parallelizable(ParallelScope.All)]
 public class BadBlockStoreTests
 {
     [Test]

src/Nethermind/Nethermind.Blockchain.Test/Blocks/BlockStoreTests.cs

@@ -15,6 +15,7 @@
 
 namespace Nethermind.Blockchain.Test.Blocks;
 
+[Parallelizable(ParallelScope.All)]
 public class BlockStoreTests
 {
     private readonly Func<EquivalencyAssertionOptions<Block>, EquivalencyAssertionOptions<Block>> _ignoreEncodedSize = options => options.Excluding(b => b.EncodedSize);

src/Nethermind/Nethermind.Blockchain.Test/Blocks/HeaderStoreTests.cs

@@ -11,9 +11,9 @@
 
 namespace Nethermind.Blockchain.Test.Blocks;
 
+[Parallelizable(ParallelScope.All)]
 public class HeaderStoreTests
 {
-
     [Test]
     public void TestCanStoreAndGetHeader()
     {

src/Nethermind/Nethermind.Blockchain.Test/CachedCodeInfoRepositoryTests.cs

@@ -19,6 +19,7 @@
 namespace Nethermind.Blockchain.Test;
 
 [TestFixture]
+[Parallelizable(ParallelScope.All)]
 public class CachedCodeInfoRepositoryTests
 {
     private static IReleaseSpec CreateSpecWithPrecompile(Address precompileAddress)

src/Nethermind/Nethermind.Blockchain.Test/ChainHeadReadOnlyStateProviderTests.cs

@@ -9,6 +9,7 @@
 
 namespace Nethermind.Blockchain.Test;
 
+[Parallelizable(ParallelScope.All)]
 public class ChainHeadReadOnlyStateProviderTests
 {
     [Test, MaxTime(Timeout.MaxTestTime)]

src/Nethermind/Nethermind.Blockchain.Test/Consensus/ClefSignerTests.cs

@@ -15,6 +15,7 @@
 namespace Nethermind.Blockchain.Test.Consensus
 {
     [TestFixture]
+    [Parallelizable(ParallelScope.All)]
     public class ClefSignerTests
     {
         [Test]

src/Nethermind/Nethermind.Blockchain.Test/Consensus/CompositeTxSourceTests.cs

@@ -14,6 +14,7 @@
 
 namespace Nethermind.Blockchain.Test.Consensus;
 
+[Parallelizable(ParallelScope.All)]
 public class CompositeTxSourceTests
 {
     [Test, MaxTime(Timeout.MaxTestTime)]

src/Nethermind/Nethermind.Blockchain.Test/Consensus/NethDevSealEngineTests.cs

@@ -12,6 +12,7 @@
 namespace Nethermind.Blockchain.Test.Consensus
 {
     [TestFixture]
+    [Parallelizable(ParallelScope.All)]
     public class NethDevSealEngineTests
     {
         [Test, MaxTime(Timeout.MaxTestTime)]

src/Nethermind/Nethermind.Blockchain.Test/Consensus/NullSealEngineTests.cs

@@ -11,6 +11,7 @@
 namespace Nethermind.Blockchain.Test.Consensus
 {
     [TestFixture]
+    [Parallelizable(ParallelScope.All)]
     public class NullSealEngineTests
     {
         [Test, MaxTime(Timeout.MaxTestTime)]

src/Nethermind/Nethermind.Blockchain.Test/Consensus/NullSignerTests.cs

@@ -12,6 +12,7 @@
 namespace Nethermind.Blockchain.Test.Consensus
 {
     [TestFixture]
+    [Parallelizable(ParallelScope.All)]
     public class NullSignerTests
     {
         [Test, MaxTime(Timeout.MaxTestTime)]

src/Nethermind/Nethermind.Blockchain.Test/Consensus/OneByOneTxSourceTests.cs

@@ -11,6 +11,7 @@
 namespace Nethermind.Blockchain.Test.Consensus
 {
     [TestFixture]
+    [Parallelizable(ParallelScope.All)]
     public class OneByOneTxSourceTests
     {
         [Test, MaxTime(Timeout.MaxTestTime)]

src/Nethermind/Nethermind.Blockchain.Test/Consensus/SealEngineExceptionTests.cs

@@ -8,6 +8,7 @@
 namespace Nethermind.Blockchain.Test.Consensus
 {
     [TestFixture]
+    [Parallelizable(ParallelScope.All)]
     public class SealEngineExceptionTests
     {
         [Test, MaxTime(Timeout.MaxTestTime)]

src/Nethermind/Nethermind.Blockchain.Test/Consensus/SignerTests.cs

@@ -16,6 +16,7 @@
 namespace Nethermind.Blockchain.Test.Consensus
 {
     [TestFixture]
+    [Parallelizable(ParallelScope.All)]
     public class SignerTests
     {
         [Test, MaxTime(Timeout.MaxTestTime)]

src/Nethermind/Nethermind.Blockchain.Test/Consensus/SinglePendingTxSelectorTests.cs

@@ -11,6 +11,7 @@
 
 namespace Nethermind.Blockchain.Test.Consensus
 {
+    [Parallelizable(ParallelScope.All)]
     public class SinglePendingTxSelectorTests
     {
         private readonly BlockHeader _anyParent = Build.A.BlockHeader.TestObject;

src/Nethermind/Nethermind.Blockchain.Test/DaoDataTests.cs

@@ -7,6 +7,7 @@
 
 namespace Nethermind.Blockchain.Test;
 
+[Parallelizable(ParallelScope.All)]
 public class DaoDataTests
 {
     [Test, MaxTime(Timeout.MaxTestTime)]

src/Nethermind/Nethermind.Blockchain.Test/Data/FileLocalDataSourceTests.cs

@@ -16,6 +16,7 @@
 
 namespace Nethermind.Blockchain.Test.Data
 {
+    [Parallelizable(ParallelScope.All)]
     public class FileLocalDataSourceTests
     {
         [Test, MaxTime(Timeout.MaxTestTime)]

src/Nethermind/Nethermind.Blockchain.Test/ExitOnBlocknumberHandlerTests.cs

@@ -10,6 +10,7 @@
 
 namespace Nethermind.Blockchain.Test;
 
+[Parallelizable(ParallelScope.All)]
 public class ExitOnBlocknumberHandlerTests
 {
     [TestCase(10, false)]

src/Nethermind/Nethermind.Blockchain.Test/Filters/AddressFilterTests.cs

@@ -11,6 +11,7 @@
 namespace Nethermind.Blockchain.Test.Filters;
 
 [TestFixture]
+[Parallelizable(ParallelScope.All)]
 public class AddressFilterTests
 {
     [Test]

src/Nethermind/Nethermind.Blockchain.Test/Filters/FilterStoreTests.cs

@@ -18,6 +18,8 @@
 
 namespace Nethermind.Blockchain.Test.Filters;
 
+[Parallelizable(ParallelScope.All)]
+[FixtureLifeCycle(LifeCycle.InstancePerTestCase)]
 public class FilterStoreTests
 {
     [Test, MaxTime(Timeout.MaxTestTime)]
@@ -152,6 +154,7 @@ public void Correctly_creates_topics_filter(Hash256[]?[]? topics, TopicsFilter e
     }
 
     [Test, MaxTime(Timeout.MaxTestTime)]
+    [Parallelizable(ParallelScope.None)]
     public async Task CleanUps_filters()
     {
         List<int> removedFilterIds = new();

src/Nethermind/Nethermind.Blockchain.Test/Filters/LogFilterTests.cs

@@ -11,6 +11,8 @@
 
 namespace Nethermind.Blockchain.Test.Filters;
 
+[Parallelizable(ParallelScope.All)]
+[FixtureLifeCycle(LifeCycle.InstancePerTestCase)]
 public class LogFilterTests
 {
     private int _filterCounter;

src/Nethermind/Nethermind.Blockchain.Test/Find/LogFinderTests.cs

@@ -26,6 +26,8 @@
 
 namespace Nethermind.Blockchain.Test.Find;
 
+[Parallelizable(ParallelScope.All)]
+[FixtureLifeCycle(LifeCycle.InstancePerTestCase)]
 public class LogFinderTests
 {
     private IBlockTree _blockTree = null!;

src/Nethermind/Nethermind.Blockchain.Test/FullPruning/CopyTreeVisitorTests.cs

@@ -21,18 +21,11 @@
 
 namespace Nethermind.Blockchain.Test.FullPruning;
 
-[Parallelizable(ParallelScope.Self)]
+[Parallelizable(ParallelScope.All)]
 [TestFixture(INodeStorage.KeyScheme.HalfPath)]
 [TestFixture(INodeStorage.KeyScheme.Hash)]
-public class CopyTreeVisitorTests
+public class CopyTreeVisitorTests(INodeStorage.KeyScheme scheme)
 {
-    private readonly INodeStorage.KeyScheme _keyScheme;
-
-    public CopyTreeVisitorTests(INodeStorage.KeyScheme scheme)
-    {
-        _keyScheme = scheme;
-    }
-
     [TestCase(0, 1)]
     [TestCase(0, 8)]
     [TestCase(1, 1)]
@@ -83,7 +76,7 @@ public void cancel_coping_state_between_dbs()
     private IPruningContext CopyDb(IPruningContext pruningContext, CancellationToken cancellationToken, MemDb trieDb, VisitingOptions? visitingOptions = null, WriteFlags writeFlags = WriteFlags.None)
     {
         LimboLogs logManager = LimboLogs.Instance;
-        PatriciaTree trie = Build.A.Trie(new NodeStorage(trieDb, _keyScheme)).WithAccountsByIndex(0, 100).TestObject;
+        PatriciaTree trie = Build.A.Trie(new NodeStorage(trieDb, scheme)).WithAccountsByIndex(0, 100).TestObject;
 
         // Create a custom DbProvider that uses the trieDb from the test
         IDbProvider dbProvider = Substitute.For<IDbProvider>();
@@ -94,16 +87,16 @@ private IPruningContext CopyDb(IPruningContext pruningContext, CancellationToken
         (IWorldState worldState, IStateReader stateReader) = TestWorldStateFactory.CreateForTestWithStateReader(dbProvider, logManager);
 
         BlockHeader? baseBlock = Build.A.BlockHeader.WithStateRoot(trie.RootHash).TestObject;
-        if (_keyScheme == INodeStorage.KeyScheme.Hash)
+        if (scheme == INodeStorage.KeyScheme.Hash)
         {
-            NodeStorage nodeStorage = new NodeStorage(pruningContext, _keyScheme);
+            NodeStorage nodeStorage = new NodeStorage(pruningContext, scheme);
             using CopyTreeVisitor<NoopTreePathContextWithStorage> copyTreeVisitor = new(nodeStorage, writeFlags, logManager, cancellationToken);
             stateReader.RunTreeVisitor(copyTreeVisitor, baseBlock, visitingOptions);
             copyTreeVisitor.Finish();
         }
         else
         {
-            NodeStorage nodeStorage = new NodeStorage(pruningContext, _keyScheme);
+            NodeStorage nodeStorage = new NodeStorage(pruningContext, scheme);
             using CopyTreeVisitor<TreePathContextWithStorage> copyTreeVisitor = new(nodeStorage, writeFlags, logManager, cancellationToken);
             stateReader.RunTreeVisitor(copyTreeVisitor, baseBlock, visitingOptions);
             copyTreeVisitor.Finish();

src/Nethermind/Nethermind.Blockchain.Test/FullPruning/FullPrunerTests.cs

@@ -30,18 +30,10 @@ namespace Nethermind.Blockchain.Test.FullPruning;
 [TestFixture(0, 4)]
 [TestFixture(1, 1)]
 [TestFixture(1, 4)]
-[Parallelizable(ParallelScope.Children)]
-public class FullPrunerTests
+[Parallelizable(ParallelScope.All)]
+[FixtureLifeCycle(LifeCycle.InstancePerTestCase)]
+public class FullPrunerTests(int fullPrunerMemoryBudgetMb, int degreeOfParallelism)
 {
-    private readonly int _fullPrunerMemoryBudgetMb;
-    private readonly int _degreeOfParallelism;
-
-    public FullPrunerTests(int fullPrunerMemoryBudgetMb, int degreeOfParallelism)
-    {
-        _fullPrunerMemoryBudgetMb = fullPrunerMemoryBudgetMb;
-        _degreeOfParallelism = degreeOfParallelism;
-    }
-
     [Test, MaxTime(Timeout.MaxTestTime)]
     public async Task can_prune()
     {
@@ -61,8 +53,8 @@ public async Task can_prune_and_switch_key_scheme(INodeStorage.KeyScheme current
             true,
             false,
             FullPruningCompletionBehavior.None,
-            _fullPrunerMemoryBudgetMb,
-            _degreeOfParallelism,
+            fullPrunerMemoryBudgetMb,
+            degreeOfParallelism,
             currentKeyScheme: currentKeyScheme,
             preferredKeyScheme: newKeyScheme);
 
@@ -192,8 +184,8 @@ private TestContext CreateTest(
             successfulPruning,
             clearPrunedDb,
             completionBehavior,
-            _fullPrunerMemoryBudgetMb,
-            _degreeOfParallelism);
+            fullPrunerMemoryBudgetMb,
+            degreeOfParallelism);
 
     private class TestContext
     {

src/Nethermind/Nethermind.Blockchain.Test/FullPruning/FullPruningDiskTest.cs

@@ -30,6 +30,7 @@
 
 namespace Nethermind.Blockchain.Test.FullPruning;
 
+[Parallelizable(ParallelScope.All)]
 public class FullPruningDiskTest
 {
     public class PruningTestBlockchain : TestBlockchain
@@ -109,27 +110,24 @@ public static async Task<PruningTestBlockchain> Create(IPruningConfig? pruningCo
             return chain;
         }
 
-        public class FullTestPruner : FullPruner
+        public class FullTestPruner(
+            IFullPruningDb pruningDb,
+            INodeStorageFactory nodeStorageFactory,
+            INodeStorage mainNodeStorage,
+            IPruningTrigger pruningTrigger,
+            IPruningConfig pruningConfig,
+            IBlockTree blockTree,
+            IStateReader stateReader,
+            IProcessExitSource processExitSource,
+            IDriveInfo driveInfo,
+            IPruningTrieStore trieStore,
+            IChainEstimations chainEstimations,
+            ILogManager logManager)
+            : FullPruner(pruningDb, nodeStorageFactory, mainNodeStorage, pruningTrigger, pruningConfig, blockTree,
+                stateReader, processExitSource, chainEstimations, driveInfo, trieStore, logManager)
         {
             public EventWaitHandle WaitHandle { get; } = new ManualResetEvent(false);
 
-            public FullTestPruner(
-                IFullPruningDb pruningDb,
-                INodeStorageFactory nodeStorageFactory,
-                INodeStorage mainNodeStorage,
-                IPruningTrigger pruningTrigger,
-                IPruningConfig pruningConfig,
-                IBlockTree blockTree,
-                IStateReader stateReader,
-                IProcessExitSource processExitSource,
-                IDriveInfo driveInfo,
-                IPruningTrieStore trieStore,
-                IChainEstimations chainEstimations,
-                ILogManager logManager)
-                : base(pruningDb, nodeStorageFactory, mainNodeStorage, pruningTrigger, pruningConfig, blockTree, stateReader, processExitSource, chainEstimations, driveInfo, trieStore, logManager)
-            {
-            }
-
             protected override async Task RunFullPruning(CancellationToken cancellationToken)
             {
                 await base.RunFullPruning(cancellationToken);

src/Nethermind/Nethermind.Blockchain.Test/FullPruning/PruningTriggerPruningStrategyTests.cs

@@ -12,7 +12,8 @@
 namespace Nethermind.Blockchain.Test.FullPruning
 {
     [TestFixture]
-    [Parallelizable(ParallelScope.Self)]
+    [Parallelizable(ParallelScope.All)]
+    [FixtureLifeCycle(LifeCycle.InstancePerTestCase)]
     public class PruningTriggerPruningStrategyTests
     {
         private IFullPruningDb _fullPruningDb;

src/Nethermind/Nethermind.Blockchain.Test/Producers/BuildBlockOnEachPendingTxTests.cs

@@ -10,6 +10,7 @@
 
 namespace Nethermind.Blockchain.Test.Producers;
 
+[Parallelizable(ParallelScope.All)]
 public class BuildBlockOnEachPendingTxTests
 {
     [Test, MaxTime(Timeout.MaxTestTime)]