Implement Block-level access lists (EIP-7928)#10357
Merged
Conversation
… blockchain test runners
flcl42
force-pushed
the
bal-devnet-2-bals-only
branch
from
717e407 to
274638f
Compare
Contributor
EVM Opcode Benchmark DiffAggregated runs: base=1, pr=1 Regressions (2)
|
flcl42
approved these changes
Mar 2, 2026
LukaszRozmej
reviewed
Mar 3, 2026
src/Nethermind/Nethermind.Consensus/Processing/BlockProcessor.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Consensus/Processing/BlockProcessor.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Consensus/Validators/BlockValidator.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Consensus/Validators/HeaderValidator.cs
Outdated
Show resolved
Hide resolved
Comment on lines
+313
to
+316
| if (_balBuilder is not null && _balBuilder.TracingEnabled && IncludeAccountRead(authorizationResult)) | ||
| { | ||
| _balBuilder.AddAccountRead(authority); | ||
| } |
Member
There was a problem hiding this comment.
At least extension method. But maybe better it should be in IsValidForExecution directly? But maybe better why WorldState.HasCode and WorldState.GetNonce in IsValidForExecution don't do it by themselves?
src/Nethermind/Nethermind.Merge.Plugin/Handlers/GetPayloadBodiesByHashV1Handler.cs
Show resolved
Hide resolved
src/Nethermind/Nethermind.Merge.Plugin/Handlers/GetPayloadBodiesByHashV2Handler.cs
Outdated
Show resolved
Hide resolved
LukaszRozmej
approved these changes
Mar 9, 2026
Contributor
Block Processing Benchmark ComparisonRun: View workflow run
Detailed statistics
|
benaadams
reviewed
Mar 9, 2026
benaadams
approved these changes
Mar 9, 2026
Contributor
EXPB Benchmark ComparisonRun: View workflow run superblocksScenario:
realblocksScenario:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update
Requires explanation in Release Notes