Fix test endpoint to match transport semantics for multiple JSON requests #10356
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Co-authored-by: LukaszRozmej <12445221+LukaszRozmej@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update handling of incoming JSONs in chunks
Fix test endpoint to match transport semantics for multiple JSON requests
Jan 30, 2026
LukaszRozmej
approved these changes
Jan 30, 2026
LukaszRozmej
merged commit 86a8537
into
feature/parse_json_in_chunks
130 of 132 checks passed
LukaszRozmej
added a commit
that referenced
this pull request
Feb 1, 2026
* Parse incoming Jsons in chunks * changes * better error handling * move start time * dispose jsondocument on exception * fix microseconds * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix copilot review * whitespace * fix TrimStart * Guard ReadAsync * fix * Fix test endpoint to match transport semantics for multiple JSON requests (#10356) * Initial plan * Change test endpoint from Http to Ws for multiple requests test Co-authored-by: LukaszRozmej <12445221+LukaszRozmej@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: LukaszRozmej <12445221+LukaszRozmej@users.noreply.github.com> * Update src/Nethermind/Nethermind.JsonRpc/JsonRpcProcessor.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fixes * more fixes * Update src/Nethermind/Nethermind.JsonRpc.Test/JsonRpcProcessorTests.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * make http endpoint AllowMultipleValues = false --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Ben {chmark} Adams <thundercat@illyriad.co.uk> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: LukaszRozmej <12445221+LukaszRozmej@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses review feedback from #10207 regarding
Can_process_multiple_large_requests_arriving_in_chunks()test. The test sends multiple newline-delimited JSON-RPC requests but usedRpcEndpoint.Http, which breaks after the first result (perStartup.cs:296).Changes
RpcEndpoint.Wsto match WebSocket transport semantics that support multiple requests per connectionTypes of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update
Requires explanation in Release Notes
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.