Skip to content

Replace generic Exception with NotSupportedException in FlatWorldStateModule#10346

Merged
asdacap merged 2 commits intoperf/simple-flatfrom
copilot/sub-pr-9854-again
Jan 28, 2026
Merged

Replace generic Exception with NotSupportedException in FlatWorldStateModule#10346
asdacap merged 2 commits intoperf/simple-flatfrom
copilot/sub-pr-9854-again

Conversation

Copy link
Contributor

Copilot AI commented Jan 28, 2026

Changes

  • Replaced throw new Exception(...) with throw new NotSupportedException(...) for unsupported FlatDB layout configurations (line 85)
  • Replaced throw new Exception(...) with throw new NotSupportedException(...) for disabled factory components (lines 44-45)

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: asdacap <1841324+asdacap@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP address feedback on previous PR review comments Replace generic Exception with NotSupportedException in FlatWorldStateModule Jan 28, 2026
Copilot AI requested a review from asdacap January 28, 2026 12:10
@asdacap asdacap marked this pull request as ready for review January 28, 2026 12:12
@asdacap asdacap requested a review from LukaszRozmej as a code owner January 28, 2026 12:12
@asdacap asdacap merged commit 7bdccfd into perf/simple-flat Jan 28, 2026
@asdacap asdacap deleted the copilot/sub-pr-9854-again branch January 28, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants