Replace generic Exception with NotSupportedException in FlatWorldStateModule#10346
Merged
asdacap merged 2 commits intoperf/simple-flatfrom Jan 28, 2026
Merged
Replace generic Exception with NotSupportedException in FlatWorldStateModule#10346asdacap merged 2 commits intoperf/simple-flatfrom
asdacap merged 2 commits intoperf/simple-flatfrom
Conversation
Co-authored-by: asdacap <1841324+asdacap@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback on previous PR review comments
Replace generic Exception with NotSupportedException in FlatWorldStateModule
Jan 28, 2026
asdacap
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
throw new Exception(...)withthrow new NotSupportedException(...)for unsupported FlatDB layout configurations (line 85)throw new Exception(...)withthrow new NotSupportedException(...)for disabled factory components (lines 44-45)Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update
Requires explanation in Release Notes
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.