Skip to content

refactor: remove redundant null checks in SnapProviderHelper.AddAccountRange #10298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukaszRozmej merged 2 commits into from
Jan 26, 2026
Merged

refactor: remove redundant null checks in SnapProviderHelper.AddAccountRange #10298

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
095d3de
Update SnapProviderHelper.cs
Aleksandr1732 Jan 21, 2026
df4820c
Merge branch 'master' into patch-4
LukaszRozmej Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/Nethermind/Nethermind.Synchronization/SnapSync/SnapProviderHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,10 @@ public static (AddRangeResult result, bool moreChildrenToRight, List<PathWithAcc
codeHashes.Add(account.Account.CodeHash);
}

var account_ = account.Account;
Rlp rlp = account_ is null ? null : account_.IsTotallyEmpty ? StateTree.EmptyAccountRlp : Rlp.Encode(account_);
entries.Add(new PatriciaTree.BulkSetEntry(account.Path, rlp?.Bytes));
if (account is not null)
{
Interlocked.Add(ref Metrics.SnapStateSynced, rlp.Bytes.Length);
}
Account accountValue = account.Account;
Rlp rlp = accountValue.IsTotallyEmpty ? StateTree.EmptyAccountRlp : Rlp.Encode(accountValue);
entries.Add(new PatriciaTree.BulkSetEntry(account.Path, rlp.Bytes));
Interlocked.Add(ref Metrics.SnapStateSynced, rlp.Bytes.Length);
}

tree.BulkSet(entries, PatriciaTree.Flags.WasSorted);
Expand Down