Skip to content

Warmup threads should not update tx.SpentGas #10267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damian-orzechowski merged 3 commits into from
Jan 22, 2026
Merged

Warmup threads should not update tx.SpentGas #10267

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
caa6f56
Warmup threads do not update tx.SpentGas
damian-orzechowski Jan 19, 2026
7795e6f
Merge branch 'master' into fix/warmup-threads-dont-update-tx-spent-gas
damian-orzechowski Jan 20, 2026
daf90d6
Merge branch 'master' into fix/warmup-threads-dont-update-tx-spent-gas
damian-orzechowski Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,11 @@ protected enum ExecutionOptions
/// </summary>
SkipValidation = 4,

/// <summary>
/// Marker option used by state pre-warmer
/// </summary>
Warmup = 8,

/// <summary>
/// Skip potential fail checks and commit state after execution
/// </summary>
Expand Down Expand Up @@ -155,7 +160,7 @@ public TransactionResult Trace(Transaction transaction, ITxTracer txTracer) =>
ExecuteCore(transaction, txTracer, ExecutionOptions.SkipValidationAndCommit);

public virtual TransactionResult Warmup(Transaction transaction, ITxTracer txTracer) =>
ExecuteCore(transaction, txTracer, ExecutionOptions.SkipValidation);
ExecuteCore(transaction, txTracer, ExecutionOptions.Warmup | ExecutionOptions.SkipValidation);

private TransactionResult ExecuteCore(Transaction tx, ITxTracer tracer, ExecutionOptions opts)
{
Expand Down Expand Up @@ -222,7 +227,10 @@ protected virtual TransactionResult Execute(Transaction tx, ITxTracer tracer, Ex
ExecuteEvmCall<OnFlag>(tx, header, spec, tracer, opts, delegationRefunds, intrinsicGas, accessTracker, gasAvailable, env, out substate, out spentGas);

PayFees(tx, header, spec, tracer, in substate, spentGas.SpentGas, premiumPerGas, blobBaseFee, statusCode);
tx.SpentGas = spentGas.SpentGas;

//only main thread updates transaction
if (!opts.HasFlag(ExecutionOptions.Warmup))
Comment thread
LukaszRozmej marked this conversation as resolved.
tx.SpentGas = spentGas.SpentGas;

// Finalize
if (restore)
Expand Down