Skip to content

fix(evm): Add MaxFeePerBlobGas validation per EIP-4844 #10206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bshastry wants to merge 2 commits into from
Closed

fix(evm): Add MaxFeePerBlobGas validation per EIP-4844 #10206

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e7b2fd
fix(evm): Add MaxFeePerBlobGas validation per EIP-4844
bshastry Jan 13, 2026
afb6a15
Merge branch 'master' into fix/blob-gas-validation
bshastry Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,16 @@ protected virtual TransactionResult BuyGas(Transaction tx, IReleaseSpec spec, IT
TraceLogInvalidTx(tx, $"INSUFFICIENT_MAX_FEE_PER_BLOB_GAS_FOR_SENDER_BALANCE: ({tx.SenderAddress})_BALANCE = {senderBalance}");
return TransactionResult.InsufficientSenderBalance;
}

// Check that tx.MaxFeePerBlobGas >= feePerBlobGas (the current blob gas price)
if (validate && BlobGasCalculator.TryCalculateFeePerBlobGas(header, spec.BlobBaseFeeUpdateFraction, out UInt256 feePerBlobGas))
{
if ((UInt256)tx.MaxFeePerBlobGas! < feePerBlobGas)
{
TraceLogInvalidTx(tx, $"INSUFFICIENT_MAX_FEE_PER_BLOB_GAS: tx.MaxFeePerBlobGas ({tx.MaxFeePerBlobGas}) < feePerBlobGas ({feePerBlobGas})");
return TransactionResult.InsufficientMaxFeePerBlobGas;
}
Comment on lines +555 to +562
Copy link
Member

@LukaszRozmej LukaszRozmej Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So before we actually go to processing a block (through BlockProcessor and TransactionProcessor) it goes through BlockValidator. We have this validation in BlockValidator.ValidateEip4844Fields.

So having it here is a bit redundant for us.

Copy link
Member

@LukaszRozmej LukaszRozmej Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the test you are running is not setup properly?

Copy link
Contributor Author

@bshastry bshastry Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm running a statetest using nethtest that doesn't pass through the block validator. Hence this duplication.

Do you have other suggestions so fuzzer can be silenced when blob fee is incorrect and it doesn't flag it as a consensus issue?

Copy link
Contributor

@flcl42 flcl42 Jan 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me try to add block validator there

Copy link
Contributor

@flcl42 flcl42 Jan 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you share the test please, to confirm it now does not pass?

Copy link
Contributor Author

@bshastry bshastry Jan 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nethtest -m -i test.json for the test below should fail on master (enter the contract call with the stop instruction in the trace) but pass on this branch (no call trace). The stateroot is for this branch's expectation.

{
  "insufficientMaxFeePerBlobGas_EIP4844": {
    "_info": {
      "comment": "Test that blob transactions are rejected when MaxFeePerBlobGas < current blob gas price (EIP-4844)",
      "filling-transition-tool": "Nethermind EVM",
      "description": "This test verifies that a blob transaction with MaxFeePerBlobGas=1 is rejected when the block's excessBlobGas results in feePerBlobGas=2. Without the EIP-4844 MaxFeePerBlobGas validation fix, this transaction would incorrectly be accepted.",
      "url": "https://eips.ethereum.org/EIPS/eip-4844"
    },
    "env": {
      "currentCoinbase": "0x2adc25665018aa1fe0e6bc666dac8fc2697ff9ba",
      "currentGasLimit": "0x016345785d8a0000",
      "currentNumber": "0x01",
      "currentTimestamp": "0x03e8",
      "currentRandom": "0x0000000000000000000000000000000000000000000000000000000000000000",
      "currentDifficulty": "0x00",
      "currentBaseFee": "0x01",
      "currentExcessBlobGas": "0x32f0ed"
    },
    "pre": {
      "0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b": {
        "nonce": "0x00",
        "balance": "0x0de0b6b3a7640000",
        "code": "0x",
        "storage": {}
      },
      "0x0000000000000000000000000000000000001000": {
        "nonce": "0x00",
        "balance": "0x00",
        "code": "0x00",
        "storage": {}
      }
    },
    "transaction": {
      "type": "0x03",
      "nonce": "0x00",
      "maxPriorityFeePerGas": "0x01",
      "maxFeePerGas": "0x01",
      "gasLimit": [
        "0x5208"
      ],
      "to": "0x0000000000000000000000000000000000001000",
      "value": [
        "0x00"
      ],
      "data": [
        "0x"
      ],
      "maxFeePerBlobGas": "0x01",
      "blobVersionedHashes": [
        "0x0100000000000000000000000000000000000000000000000000000000000000"
      ],
      "sender": "0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b",
      "secretKey": "0x45a915e4d060149eb4365960e6a7a45f334393093061116b197e3240065ff2d8"
    },
    "post": {
      "Cancun": [
        {
          "expectException": "TR_InsufficientMaxFeePerBlobGas",
          "hash": "0x44b4804a96216f31b8d08d1ddb86f7b624c4bc0c0ad986cfedf18ea8d4a3c1da",
          "logs": "0x1dcc4de8dec75d7aab85b567b6ccd41ad312451b948a7413f0a142fd40d49347",
          "indexes": {
            "data": 0,
            "gas": 0,
            "value": 0
          }
        }
      ]
    }
  }
}

}
}
}

Expand Down Expand Up @@ -984,6 +994,7 @@ private TransactionResult(ErrorType error = ErrorType.None, EvmExceptionType evm
ErrorType.GasLimitBelowIntrinsicGas => "gas limit below intrinsic gas",
ErrorType.InsufficientMaxFeePerGasForSenderBalance => "insufficient MaxFeePerGas for sender balance",
ErrorType.InsufficientSenderBalance => "insufficient sender balance",
ErrorType.InsufficientMaxFeePerBlobGas => "max fee per blob gas less than block blob gas fee",
ErrorType.MalformedTransaction => "malformed",
ErrorType.MinerPremiumNegative => "miner premium is negative",
ErrorType.NonceOverflow => "nonce overflow",
Expand Down Expand Up @@ -1015,6 +1026,7 @@ public static TransactionResult EvmException(EvmExceptionType evmExceptionType,
public static readonly TransactionResult GasLimitBelowIntrinsicGas = ErrorType.GasLimitBelowIntrinsicGas;
public static readonly TransactionResult InsufficientMaxFeePerGasForSenderBalance = ErrorType.InsufficientMaxFeePerGasForSenderBalance;
public static readonly TransactionResult InsufficientSenderBalance = ErrorType.InsufficientSenderBalance;
public static readonly TransactionResult InsufficientMaxFeePerBlobGas = ErrorType.InsufficientMaxFeePerBlobGas;
public static readonly TransactionResult MalformedTransaction = ErrorType.MalformedTransaction;
public static readonly TransactionResult MinerPremiumNegative = ErrorType.MinerPremiumNegative;
public static readonly TransactionResult NonceOverflow = ErrorType.NonceOverflow;
Expand All @@ -1031,6 +1043,7 @@ public enum ErrorType
GasLimitBelowIntrinsicGas,
InsufficientMaxFeePerGasForSenderBalance,
InsufficientSenderBalance,
InsufficientMaxFeePerBlobGas,
MalformedTransaction,
MinerPremiumNegative,
NonceOverflow,
Expand Down