Skip to content

refactor: split ClHealthTrackerTests into separate test methods #10171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukaszRozmej merged 3 commits into from
Jan 14, 2026
Merged

refactor: split ClHealthTrackerTests into separate test methods #10171

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
567eaf1
Update ClHealthTrackerTests.cs
DeVikingMark Jan 9, 2026
d51fe4d
Update ClHealthTrackerTests.cs
DeVikingMark Jan 13, 2026
d9f5834
Merge branch 'master' into refactor/split-cl-health-tracker-test
LukaszRozmej Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 69 additions & 18 deletions src/Nethermind/Nethermind.HealthChecks.Test/ClHealthTrackerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// SPDX-License-Identifier: LGPL-3.0-only

using System;
using System.Threading.Tasks;
using FluentAssertions;
using Nethermind.Core;
using Nethermind.Logging;
Expand All @@ -12,44 +11,96 @@ namespace Nethermind.HealthChecks.Test;

public class ClHealthTrackerTests
{
[Test]
public async Task ClHealthRequestsTracker_multiple_requests()
private const int MaxIntervalSeconds = 300;

private static ClHealthRequestsTracker CreateHealthTracker(ManualTimestamper timestamper)
{
ManualTimestamper timestamper = new(DateTime.Parse("18:23:00"));
await using ClHealthRequestsTracker healthTracker = new(
return new ClHealthRequestsTracker(
timestamper,
new HealthChecksConfig()
{
MaxIntervalClRequestTime = 300
MaxIntervalClRequestTime = MaxIntervalSeconds
}, LimboLogs.Instance);
}

[Test]
public void CheckClAlive_Initially_ReturnsTrue()
{
ManualTimestamper timestamper = new(DateTime.Parse("18:23:00"));
ClHealthRequestsTracker healthTracker = CreateHealthTracker(timestamper);

healthTracker.CheckClAlive().Should().BeTrue();
}

timestamper.Add(TimeSpan.FromSeconds(299));
healthTracker.CheckClAlive().Should().BeTrue(); // Not enough time from start
[Test]
public void CheckClAlive_AfterMaxInterval_ReturnsFalse()
{
ManualTimestamper timestamper = new(DateTime.Parse("18:23:00"));
ClHealthRequestsTracker healthTracker = CreateHealthTracker(timestamper);

timestamper.Add(TimeSpan.FromSeconds(2));
healthTracker.CheckClAlive().Should().BeFalse(); // More than 300 since start
timestamper.Add(TimeSpan.FromSeconds(MaxIntervalSeconds + 1));
healthTracker.CheckClAlive().Should().BeFalse();
}

[Test]
public void CheckClAlive_BeforeMaxInterval_ReturnsTrue()
{
ManualTimestamper timestamper = new(DateTime.Parse("18:23:00"));
ClHealthRequestsTracker healthTracker = CreateHealthTracker(timestamper);

timestamper.Add(TimeSpan.FromSeconds(MaxIntervalSeconds - 1));
healthTracker.CheckClAlive().Should().BeTrue();
}

[Test]
public void CheckClAlive_AfterForkchoiceUpdated_ResetsTimer()
{
ManualTimestamper timestamper = new(DateTime.Parse("18:23:00"));
ClHealthRequestsTracker healthTracker = CreateHealthTracker(timestamper);

timestamper.Add(TimeSpan.FromSeconds(MaxIntervalSeconds + 1));
healthTracker.CheckClAlive().Should().BeFalse();

healthTracker.OnForkchoiceUpdatedCalled();
healthTracker.CheckClAlive().Should().BeTrue(); // Fcu
healthTracker.CheckClAlive().Should().BeTrue();
}

[Test]
public void CheckClAlive_AfterNewPayload_ResetsTimer()
{
ManualTimestamper timestamper = new(DateTime.Parse("18:23:00"));
ClHealthRequestsTracker healthTracker = CreateHealthTracker(timestamper);

timestamper.Add(TimeSpan.FromSeconds(MaxIntervalSeconds + 1));
healthTracker.CheckClAlive().Should().BeFalse();

healthTracker.OnNewPayloadCalled();
healthTracker.CheckClAlive().Should().BeTrue(); // Fcu + Np
healthTracker.CheckClAlive().Should().BeTrue();
}

timestamper.Add(TimeSpan.FromSeconds(301));
healthTracker.CheckClAlive().Should().BeFalse(); // Big gap since fcu + Np
[Test]
public void CheckClAlive_WithBothRequests_WorksCorrectly()
{
ManualTimestamper timestamper = new(DateTime.Parse("18:23:00"));
ClHealthRequestsTracker healthTracker = CreateHealthTracker(timestamper);

healthTracker.OnForkchoiceUpdatedCalled();
healthTracker.CheckClAlive().Should().BeTrue();

timestamper.Add(TimeSpan.FromSeconds(301));
healthTracker.CheckClAlive().Should().BeFalse(); // Big gap

healthTracker.OnNewPayloadCalled();
healthTracker.CheckClAlive().Should().BeTrue();

timestamper.Add(TimeSpan.FromSeconds(299));
timestamper.Add(TimeSpan.FromSeconds(MaxIntervalSeconds + 1));
healthTracker.CheckClAlive().Should().BeFalse();
}

[Test]
public void CheckClAlive_AtBoundaryConditions_WorksCorrectly()
{
ManualTimestamper timestamper = new(DateTime.Parse("18:23:00"));
ClHealthRequestsTracker healthTracker = CreateHealthTracker(timestamper);

timestamper.Add(TimeSpan.FromSeconds(MaxIntervalSeconds - 1));
healthTracker.OnForkchoiceUpdatedCalled();
healthTracker.CheckClAlive().Should().BeTrue();

Expand Down