Remove duplicate GetContentLength calls in receipt encoder#10161
Closed
splinter012 wants to merge 1 commit intoNethermindEth:masterfrom
Closed
Remove duplicate GetContentLength calls in receipt encoder#10161splinter012 wants to merge 1 commit intoNethermindEth:masterfrom
splinter012 wants to merge 1 commit intoNethermindEth:masterfrom
Conversation
Contributor
|
What are the extra allocations? |
LukaszRozmej
reviewed
Jan 9, 2026
Comment on lines
91
to
94
| for (int i = 0; i < items.Length; i++) | ||
| { | ||
| CompactDecoder.Encode(stream, items[i], rlpBehaviors); | ||
| } |
Member
There was a problem hiding this comment.
You could set encoder variable and unify this part after else too.
LukaszRozmej
reviewed
Jan 9, 2026
Comment on lines
+86
to
89
| if (useCompactEncoding) | ||
| { | ||
| int totalLength = GetContentLength(items, rlpBehaviors); | ||
| stream.WriteByte(CompactEncoding); | ||
| stream.StartSequence(totalLength - 1); |
Member
There was a problem hiding this comment.
And do something like
var decoder = Decoder;
if (useCompactEncoding)
{
stream.WriteByte(CompactEncoding);
totalLength -= 1;
decoder = CompactDecoder;
}
stream.StartSequence(totalLength);
Member
|
this is only slight refactor, closing for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compute GetContentLength once in ReceiptArrayStorageDecoder.Encode and reuse for both compact and legacy branches, keep behavior identical while avoiding redundant work and extra allocations, no other code paths touched; lints clean on modified file