fix(sync): use INetworkConfig constructor for SyncPeerPool DI registration #10158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation SyncPeerPool was ignoring the configured MaxActivePeers value and always using a hardcoded default of 100 peers. Root cause: SyncPeerPool has two constructors: 1. One taking INetworkConfig that reads ActivePeersMaxCount from config 2. One with default parameters (peersMaxCount = 100) The DI registration `.AddSingleton<SyncPeerPool>()` allowed Autofac to pick a constructor automatically. Autofac selected the constructor with default parameters, completely bypassing INetworkConfig. This caused SyncPeerPool.PeerMaxCount to always be 100 regardless of the configured Network.MaxActivePeers value. Fix: Use explicit factory registration that specifies INetworkConfig as a dependency, ensuring the correct constructor is called with config values.
Savid
requested review from
LukaszRozmej,
asdacap,
benaadams,
flcl42 and
marcindsobczak
as code owners
LukaszRozmej
approved these changes
Jan 9, 2026
Contributor
|
Hi, thanks for finding the bug. Can you use this attribute instead? |
MarekM25
reviewed
Jan 9, 2026
Contributor
MarekM25
left a comment
MarekM25
left a comment
There was a problem hiding this comment.
Is it possible to write the test?
asdacap
approved these changes
Jan 12, 2026
LukaszRozmej
approved these changes
Jan 12, 2026
benaadams
added a commit
that referenced
this pull request
Jan 21, 2026
* fix: NodeKey.GetHashCode() violates Equals/GetHashCode contract (#9744) * chore: remove dead IsSyncing field and its assignment (#9790) * chore: remove dead IsSyncing field and its assignment * Apply suggestion from @LukaszRozmej * Simplify result creation in SyncingSubscription Refactor SyncingSubscription logic for clarity and efficiency. * Fix resource leak by using 'using' statement --------- Co-authored-by: Lukasz Rozmej <[email protected]> * Move engaging NoGC out of hot path (#9799) * Move engaging NoGC out of hot path * AI was right * Better naming * chore: remove duplicate AddDatabase registrations in DbModule (#9802) * chore: streamline nullability suppression in LruCache (#9796) Update LruCache.cs * Remove unused transaction hash collections in SendBlobs CLI (#9798) Update SetupCli.cs * Reduce storage tracking allocations (#9664) * Reduce storage tracking allocations * formatting * Formatting * Switch to new * Less changes * Remove thread static * Use extension * Fast empty path * Use faster checks for StackPool * Also reset skip flag * Feedback * Fix * AI feedback * formatting * Devirtualize filter{store | manager} (#9779) * Devirtualize filter{store | manager} * Feedback * Lets not get fancy * More specific * Feedback * Cache masternode quorum math in VotesManager (#9794) Update VotesManager.cs * fix: RlpxHost.Init guard to reference RlpxHost instead of PeerManager (#9805) * chore: remove unused block parameter (#9814) * Remove defensive copies from SecP256k1 (#9817) * Remove defensive copies from SecP256k1 * Remove type entirely * Remove unneeded .ToArray() * Max optimize * Allow Inner Reverts for eth_gasEstimate (#9822) * address inner revert for eth_gasEstimate * add new error type * fix: mismatches in error messages (#9823) fix mismatches in error messages * fix: avoid allocation in PutSpan by throwing immediately (#9819) * fix: avoid allocation in PutSpan by throwing immediately * Update RpcDb.cs * Fix merge issue (#9824) * Fix ColumnsDb constructor recursion and reuse resolved keys (#9818) * Update ColumnsDb.cs * Update ColumnsDb.cs * Resolve Transitive dependency warnings (#9827) * Resolve Transitive dependency warnings * Update Directory.Packages.props Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> * Fix buyGas in simulate (#9761) * test * Try fix * Try fix * Remove flag from non rpc calls * Fix json rpc tests * Fix more tests * Fix system tx processor * Fix blockchain tests * More fixes * Update src/Nethermind/Nethermind.Taiko/TaikoTransactionProcessor.cs Co-authored-by: Copilot <[email protected]> * Fix restore * Fix small issues * Update src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs Co-authored-by: Lukasz Rozmej <[email protected]> * known failing tests --------- Co-authored-by: Lukasz Rozmej <[email protected]> Co-authored-by: Copilot <[email protected]> * Remove redundant Math.Min call in SnapServer storage guard (#9828) Update SnapServer.cs * Remove unnecessary pragma suppression from SortedPool events (#9830) Update SortedPool.Events.cs * Shrink ReadToEndAsync async machine (#9831) * Shrink ReadToEndAsync async machine * Update src/Nethermind/Nethermind.JsonRpc/PipeReaderExtensions.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> * Optimize BlockParameter parsing (#9835) * fix: correct EOFCREATE error message (#9836) * chore: remove unused ShouldSerialize hooks and fix nullable properties (#9820) * chore: remove unused ShouldSerialize hooks and fix nullable properties * remove private readonly bool _isAuRaBlock * fix build --------- Co-authored-by: Marcos Antonio Maceo <[email protected]> Co-authored-by: Lukasz Rozmej <[email protected]> * Auto-update fast sync settings (#9840) Co-authored-by: rubo <[email protected]> * Update OP Superchain chains (#9841) Co-authored-by: emlautarom1 <[email protected]> * fix: keep PeerPool commit loop running when no pending changes (#9839) * chore(init): remove unused StateReader assignment in InitializeBlockchain (#9843) Update InitializeBlockchain.cs * Increase precision of gas price logging (#9845) * Fast path JwtAuthentication (#9837) * Fast path JwtAuthentication * AI complaining * fix: add missing string interpolation (#9851) * fix: dispose automatic pruning triggers to stop background timers (#9847) * fix: dispose automatic pruning triggers to stop background timers * Update PruningTrieStateFactory.cs * Update CompositePruningTrigger.cs * Apply suggestions from code review Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Lukasz Rozmej <[email protected]> Co-authored-by: Copilot <[email protected]> * fix: remove unused IHttpContextFactory resolution in StartAsync (#9857) * fix: use ArgumentNullException for ecdsa parameter (#9858) * Fix some spelling, add dictionary (#9850) * Fix some spelling, add dictionary * Fix bundle * Apply review feedback: fix typo and simplify test string (#9863) * Initial plan * Apply both suggestions: fix "Since" → "Sync" typo and simplify test string Co-authored-by: flcl42 <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: flcl42 <[email protected]> --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: flcl42 <[email protected]> * Fail fast for missing precompile (#9862) * Fail fast for missing precompile * fomatting * fix(txpool): race condition in NonceManager.TxWithNonceReceived (#9861) * Dispose plugins when supported (#9848) * Dispose plugins if needed * Fix redundant allocation in IXdcHeaderStore.BulkInsert (#9829) Update IXdcHeaderStore.cs * perf: avoid extra allocation by iterating snapshot (#9842) * Adjust JOC Bootnodes according to recent changes (#9869) fix: adjust joc bootnodes * fix leak in NettyDiscoveryBaseHandler (#9873) * Don't cache current block cache (#9852) * Don't cache current block cache, this makes cache usable for block production where current block hash is unknown * refactors * slight refactor * more simplification * fix * fixes for Hash being null - block production * fix for prefetch * fix test * remove redundant check * Reduce Evm Exceptions (#9808) * Reduce Evm Memory Exceptions * Reduce exceptions further * Compile issue * AI feedback * AI feedback * Add test coverage for out-of-gas conditions in memory operations (#9811) * Initial plan * Add out-of-gas test coverage for memory operations Co-authored-by: benaadams <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: benaadams <[email protected]> * Reduce casts * Change to tryX pattern --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: benaadams <[email protected]> * Bump up the version to 1.37.0-unstable (#9871) Co-authored-by: stdevMac <[email protected]> * Taiko Shasta Changes (#9709) * initial changes * make l1BlockHeight optional in L1Origin * fix field name inconsistency in NMC and Geth * undo field name change (catalyst fixed) * shasta devnet fixes * address review comments and fix issues --------- Co-authored-by: Ahmad Bitar <[email protected]> * fix: invert post-merge difficulty validation logic in T8n tool (#9880) * Changed default PublicKey serialization to use hash format (#9696) * Changed default PublicKey serialization to use hash format * Added tests for PublicKey serialization format changes * removed comments, parsed JSON properly, fixed naming convention * Added regression tests for PublicKey serialization changes * removed previous combined test file * updated regression tests to verify byte content produced by each converter * removed linq skip and take * removed tests that validate unsupported inputs * ran dotnet format --------- Co-authored-by: Stavros Vlachakis <[email protected]> * Fix Jovian fork id (#9877) * Fix Jovian fork id * Add test * Fix Base Mainnet test * Formatting --------- Co-authored-by: Lautaro Emanuel <[email protected]> * fix: tie readonly DB provider to env lifetime and clear per-scope buffers (#9883) * fix: remove duplicate EIP-7702 transaction counting in TxPool (#9885) * fix: prevent EVM memory size overflow crash for extreme memory requests (#9887) fix: prevent EVM memory size overflow crash for large memory requests The memory validation in CheckMemoryAccessViolation was checking against long.MaxValue, but .NET arrays are limited to int.MaxValue. When memory requests exceeded int.MaxValue but were less than long.MaxValue, the word-aligned size calculation would overflow when cast to int, causing ArrayPool.Rent() to allocate an incorrectly sized array and subsequent Array.Copy operations to crash. This fix changes the limit from long.MaxValue to (int.MaxValue - WordSize + 1) to ensure that after word alignment, the resulting size still fits in int. Root cause: - Memory size validation checked: totalSize > long.MaxValue - But .NET arrays require: (int)Size to be valid - Word alignment adds up to 31 bytes: Size = totalSize + (32 - totalSize % 32) - When totalSize > int.MaxValue - 31, (int)Size overflows Example crash scenario: 1. Contract requests 4GB (0xffffffff) memory via DELEGATECALL 2. Validation passes (4GB < long.MaxValue) 3. Word-aligned Size = 0x100000000 (exceeds int.MaxValue) 4. (int)Size = 0 (overflow) 5. ArrayPool.Rent(0) returns tiny array 6. Array.Copy crashes with "Destination array was not long enough" 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <[email protected]> * Auto-update fast sync settings (#9893) Co-authored-by: rubo <[email protected]> * fix: map InvalidBlockRangeUpdate to BreachOfProtocol (#9891) * Update OP Superchain chains (#9892) Co-authored-by: emlautarom1 <[email protected]> * Run taiko nodes on latest version (#9899) feat: run taiko nodes on latest version * Update Dockerfiles (#9909) Co-authored-by: rubo <[email protected]> * Disable publishing to Downloads (#9910) * chore: remove from release the upload to the downloads page * Delete publish-downloads.sh --------- Co-authored-by: Ruben Buniatyan <[email protected]> * Fix hive getLogs (#9889) * try fix * Fix tests * Try fix * Fix * Fix from & to * Fix block in the future * Fix build * Fix range in the future * Fix block range * to * Fix tests * Fix json rpc tests * Fix formatting * Fix blockchain tests * Fix suggestions * Fix tags * Remove address from AddressFilter * Fix tests * Fix address filter * Fix suggestions * fix: remove duplicate gRPC host validation in GrpcClient (#9922) * Move ExecutionEnvironment to Rentable sealed class (#9916) * Move ExecutionEnvironment to Rentable sealed class * fixes * convert to properties * fix * better * fix Benchmarks * comment * Update src/Nethermind/Nethermind.Evm.Benchmark/MultipleUnsignedOperations.cs Co-authored-by: Copilot <[email protected]> * Update src/Nethermind/Nethermind.Evm/EvmState.cs Co-authored-by: Copilot <[email protected]> * Apply suggestion from @alexb5dh Co-authored-by: Alex <[email protected]> * Refactor Disposing * fixes * Add Dispose guard --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Alex <[email protected]> * fix: align BlockHashes dictionary to use nullable Hash256 (#9900) fix: make T8nBlockHashProvider accept non-nullable Hash256 * Only pool pure Transaction objects, not subclasses (#9884) check: * Auto-update fast sync settings (#9933) Co-authored-by: rubo <[email protected]> * Update OP Superchain chains (#9932) Co-authored-by: emlautarom1 <[email protected]> * Adjust JOC testnet Bootnodes according to recent changes (#9940) fix: adjust joc testnet bootnodes * fix: Remove redundant BlockHeader field reassignments in StatelessExecution (#9928) Update SetupCli.cs * test: add Eip2565Transition check for posdao chain spec (#9920) Add missing Eip2565Transition assertion in Can_load_posdao_with_rewriteBytecode test. The test now verifies that Eip2565Transition is null for posdao.json since it uses the old modexp pricing format (divisor: 20) without modexp2565 transition. Resolves TODO comment about modexp 2565. Co-authored-by: Lukasz Rozmej <[email protected]> * Fixes #9606: DebugTracerTests thread synchronization issue (#9875) Fix DebugTracerTests thread synchronization issue (#9606) - Add vmThread.Join() calls after while loops to ensure VM threads complete before TearDown disposes the WorldState scope - Add ExecuteSafe helper method to catch ThreadInterruptedException from aborted threads - Add ThreadJoinTimeout constant to prevent tests from hanging This fixes the 'IWorldState must only be used within scope' exception that occurred when VM threads were still running during test cleanup. * Faster protocol parsing, add Ethrex (#9935) * Improve protocol parsing, add Ethrex * Add comprehensive unit tests for ProtocolParser (#9936) * Initial plan * Add comprehensive unit tests for ProtocolParser Co-authored-by: benaadams <[email protected]> * Refactor hex validation tests to reduce code duplication Co-authored-by: benaadams <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: benaadams <[email protected]> * Optimize RecognizeClientType with zero-allocation likelihood-ordered regex (#9943) * Initial plan * Optimize RecognizeClientType using compiled regex Co-authored-by: LukaszRozmej <[email protected]> * Address code review feedback: optimize regex ordering and group iteration Co-authored-by: LukaszRozmej <[email protected]> * Generate regex from enum and use FastEnum for better performance Co-authored-by: LukaszRozmej <[email protected]> * Add explanatory comments for regex pattern generation Co-authored-by: LukaszRozmej <[email protected]> * Use Regex.EnumerateMatches and ReadOnlySpan to eliminate allocations Co-authored-by: LukaszRozmej <[email protected]> * Simplify regex pattern by removing unnecessary named groups Co-authored-by: LukaszRozmej <[email protected]> * Rename to _clientTypeRegex and optimize regex order by likelihood Co-authored-by: LukaszRozmej <[email protected]> * Refactor to use Except for cleaner exclusion logic Co-authored-by: LukaszRozmej <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: LukaszRozmej <[email protected]> --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: benaadams <[email protected]> Co-authored-by: LukaszRozmej <[email protected]> * Precompiles names fix (#9944) correct names as per https://eips.ethereum.org/EIPS/eip-2537 * Update packages (#9907) * Fix hanging scenario if persisted node not able to be pruned (#9931) * Fix haning scenation if persisted node not able to be pruned * Minor comment adjustment * Reduce warning if in commit buffer mode * Separate wrong nonce errors (#9941) * Separate wrong nonce errors --------- Co-authored-by: Lukasz Rozmej <[email protected]> * Add engine_getBlobsV3 (#9942) * Add engine_getBlobsV3 --------- Co-authored-by: Lukasz Rozmej <[email protected]> * fix: only touch coinbase after successful transaction in state tests (#9865) * fix: only touch coinbase after successful transaction in state tests When a transaction fails validation (e.g., insufficient balance), the state test runner should not modify state at all. Previously, the coinbase account was created in InitializeTestState before transaction execution, causing state root divergence from geth when transactions failed validation. This fix moves coinbase creation to after successful transaction execution, matching geth's behavior: - Only touch coinbase when txResult == Ok - When validation fails, state remains unchanged from pre-state This was a consensus bug in the test framework (not production code) introduced in PR #9225. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * Update src/Nethermind/Ethereum.Test.Base/GeneralTestBase.cs * fix: update T8nExecutor to use new InitializeTestState signature The InitializeTestState method signature was changed to remove the coinbase parameter. T8nExecutor already creates the coinbase account separately (line 54), so we just need to update the call to match the new 3-argument signature. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * fix: only touch coinbase after successful transaction in state tests When a transaction fails validation (e.g., insufficient balance), the state test runner should not modify state at all. Previously, the coinbase account was created in InitializeTestState before transaction execution, causing state root divergence from geth when transactions failed validation. This fix moves coinbase creation to after successful transaction execution, matching geth's behavior: - Only touch coinbase when txResult == Ok - When validation fails, state remains unchanged from pre-state This was a consensus bug in the test framework (not production code) introduced in PR #9225. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * fix: add IsLegacy flag for backward-compatible coinbase handling in state tests Legacy tests expected coinbase to be created before transaction execution, which was a buggy behavior baked into their expected state roots. This adds an IsLegacy flag to preserve backward compatibility while new tests use the correct behavior of creating coinbase only after successful tx. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> * Update src/Nethermind/Ethereum.Test.Base/GeneralTestBase.cs Co-authored-by: Alexey Osipov <[email protected]> --------- Co-authored-by: Claude <[email protected]> Co-authored-by: Lukasz Rozmej <[email protected]> Co-authored-by: Alexey Osipov <[email protected]> * Gnosis Balancer permanent changes (#9946) * initial commit * fork info test, tidy * small tidy * load fork transition * fix test * use real gnosis json for test * simplify test * start aura check rewrite by timestamp count * reuse prague specs * osakagnosis * private praguegnosis * use array for overrides internally * formatting --------- Co-authored-by: Marc Harvey-Hill <[email protected]> * Sign release builds (#9937) * Increase default rlp collection limit to 4MB (#9957) * Auto-update fast sync settings (#9964) Co-authored-by: kamilchodola <[email protected]> * Fix/limit get proof (#9967) * limit and deduplicate getProof * const * fix merge * feat(merkle): remove unused RootOfNull to avoid dead code and startup allocation (#9898) * Fix/rlp decode array checks (#9968) * Add report test cases * Add checks to `DecodeArray` and `DecodeByteArrays` * Remove TODOs * Always check for `DecodeArray` and similar * More missing checks * fix build * compact storage encoding fix * more fix * Different way of handling compact encoding of receipts * Increase discovery tests timeout * fix * refactor --------- Co-authored-by: Lautaro Emanuel <[email protected]> * fix: dispose IEraStore when EraImporter.Import fails early (#9978) * Remove rpc from hive worflow (#9971) fix workflow * Elevate access for ABI decode override more easily (#9977) Increase access for decode * Run all tests on master (#9979) * fix * fix * Remove parsing Uint256 from statics (#9980) * perf: Remove redundant ToArray() allocation in TrieStore warning log (#9969) * Update TrieStore.cs * Update src/Nethermind/Nethermind.Trie/Pruning/TrieStore.cs --------- Co-authored-by: Lukasz Rozmej <[email protected]> * Optimise MemDb for ZK (#9952) * feat(evm): generify VirtualMachine with policy-based gas tracking (#9846) * refactor: Remove redundant try-catch in SszProperty.StaticLength (#9976) * Update SszProperty.cs * Update src/Nethermind/Nethermind.Serialization.SszGenerator/SszProperty.cs --------- Co-authored-by: Lukasz Rozmej <[email protected]> * fix: correct NSubstitute argument types in AuraWithdrawalProcessorTests (#9966) Update AuraWithdrawalProcessorTests.cs * Auto-update fast sync settings (#9989) Co-authored-by: rubo <[email protected]> * Update OP Superchain chains (#9988) Co-authored-by: emlautarom1 <[email protected]> * perf: avoid LINQ allocations in GetStorageRangesMessageSerializer (#9951) * refactor: cache blob and proof counts in BlobProofsManagerV1 (#9983) * Update BlobProofsManagerV1.cs * Update src/Nethermind/Nethermind.Crypto/BlobProofsManagerV1.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Lukasz Rozmej <[email protected]> Co-authored-by: Copilot <[email protected]> * fix: replace unused mock logger with LimboTraceLogger in EnrDiscoveryTests (#9993) Replace EnrTreeCrawler logger with LimboTraceLogger * fix: replace empty exception with informative BlockchainException in ExtractSigners (#9986) perf: avoid unnecessary block clone in block_to_payload_v3 Replace generic Exception with empty message in ExtractSigners method with BlockchainException containing descriptive error message. This aligns with project's exception handling patterns and improves debuggability. * perf(tests): Remove redundant ToList() calls in PatriciaTreeBulkSetterTests (#9981) Update PatriciaTreeBulkSetterTests.cs * Use correct HardwareAcceleration checks for Vector (#10007) * Use correct HardwareAcceleration checks for Vector * Update src/Nethermind/Nethermind.Evm/CodeAnalysis/JumpDestinationAnalyzer.cs Co-authored-by: Copilot <[email protected]> * Vector512 --------- Co-authored-by: Copilot <[email protected]> * Optimize ColumnDb MultiGet allocations (#9908) * Update ColumnDb.cs * Update ColumnDb.cs * fix: correct type name in TimeoutDecoder error message (#9948) Co-authored-by: ak88 <[email protected]> * perf: reduce allocations in TypeExtensions (#9994) * Update TypeExtensions.cs * Update TypeExtensions.cs * Update TypeExtensions.cs * refactor(trie): remove redundant condition check in IsValidWithOneNodeLess (#9982) * Update TrieNode.cs * Update src/Nethermind/Nethermind.Trie/TrieNode.cs * Update src/Nethermind/Nethermind.Trie/TrieNode.cs --------- Co-authored-by: Lukasz Rozmej <[email protected]> Co-authored-by: Ben {chmark} Adams <[email protected]> * fix: return correct count when no peer was dropped in DropWorstPeer (#10001) * Consider type boundaries (#10000) * Taiko Shasta Changes - II (#9998) * taiko-geth changes * potential fix for 'main chain predecessor cannot be found' error * address comments & add goldentouch account filter * Set release target commit explicitly (#10009) * Fix/json converters exception type (#9984) * fix: use JsonException in boolean and BigInteger converters * fix: use JsonException in boolean and BigInteger converters * Update src/Nethermind/Nethermind.Serialization.Json/BigIntegerConverter.cs Co-authored-by: Lukasz Rozmej <[email protected]> * Update src/Nethermind/Nethermind.Serialization.Json/BooleanConverter.cs Co-authored-by: Lukasz Rozmej <[email protected]> * fix ci * Update BooleanConverter.cs --------- Co-authored-by: Lukasz Rozmej <[email protected]> * refactor(tests): Remove unused variables in Enode exception tests (#9991) * Update PeerManagerTests.cs * Update PeerManagerTests.cs * Update src/Nethermind/Nethermind.Network.Test/PeerManagerTests.cs * Update PeerManagerTests.cs * Update PeerManagerTests.cs --------- Co-authored-by: Lukasz Rozmej <[email protected]> * test: replace Task.Delay with After() in ContractDataStoreTests (#9985) * Update ContractDataStoreTests.cs * Update ContractDataStoreTests.cs * Update ContractDataStoreWithLocalDataTests.cs * fix: delegate raw converters read to base converters (#10006) * fix: delegate raw converters read to base converters * fix: delegate raw converters read to base converters * fix * fix: remove duplicate HasSignedRecently checks in sealer clique (#10011) * Make Nethermind UI SSE endpoint relative (#10008) * fix: use IHttpClient from DI in MergePlugin instead of creating HttpClient directly (#9995) * Update MergePlugin.cs * Update DefaultHttpClient.cs * Update src/Nethermind/Nethermind.Merge.Plugin/MergePlugin.cs Co-authored-by: Copilot <[email protected]> * Update MergePlugin.cs * Update DefaultHttpClient.cs --------- Co-authored-by: Copilot <[email protected]> * Validate blobs lengths (#9999) * refactor(AuRa): remove redundant Create override (#10014) * Feature/Worldstate backend (#9089) * WorldState backend Fix check failure Add small test Whitespace Different setter Slight cleanup Whitespace Rename to scope provider Add code to `IWorldStateScopeProvider`. (#9291) * Add codedb * Add test * Whitespace * use span on set Fix TestworldStateFactory build Rename to update state root Refactor/Nicer IWorldStateScopeProvider interface (#9375) * Reduce interfacae surface area * Fix build * Fix random * Fix randomly failing pyspec test * Whitespace Refactor/Slight cleanup to world state write batch API. (#9400) Remove on account updated callback Fix build Feature/add back `OnAccountUpdated` (#9436) * Add back on account updated * Hint get * Update src/Nethermind/Nethermind.Evm/State/IWorldStateScopeProvider.cs Co-authored-by: Lukasz Rozmej <[email protected]> * Fix build --------- Co-authored-by: Lukasz Rozmej <[email protected]> Feature/worldstate scope provider manager (#9306) * World state manager to return scope provider * Fix build * Fix build Fix selfdestruct Fix selfdestruct not called in some case Fix build Whitespace Fix build Slight per on small contract * Fix build * Whitespace * Update src/Nethermind/Nethermind.State/TrieStoreScopeProvider.cs Co-authored-by: Marc <[email protected]> * Address comment * Make test more consistent * Extra comment * Fix precompile cache config * Remove missed comment * Address comment --------- Co-authored-by: Marc <[email protected]> * fix: use ArgumentNullException for null logManager in EthStatsClient (#10018) Update EthStatsClient.cs * fix: correct BlobTxMissingBlobs error message (#10015) * fix: correct BlobTxMissingBlobs error message * fix * Change KzgPolynomialCommitments.BlsModulus to new instead of parse (#10032) * Fix/isStorageEmpty check does not get reflected until after commit. (#10039) * ADd logger * Slightly more log * Actually fix it * Uses a different dedicated is empty check * Fix code formatting in WorldStateScopeOperationLogger (#10040) * Initial plan * Fix formatting: Add space before colon in class declaration Co-authored-by: asdacap <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: asdacap <[email protected]> * Update src/Nethermind/Nethermind.Core/Account.cs Co-authored-by: Lukasz Rozmej <[email protected]> * Update src/Nethermind/Nethermind.State/PersistentStorageProvider.cs Co-authored-by: Lukasz Rozmej <[email protected]> * Update src/Nethermind/Nethermind.State/WorldStateScopeOperationLogger.cs Co-authored-by: Lukasz Rozmej <[email protected]> * Update src/Nethermind/Nethermind.State/WorldStateScopeOperationLogger.cs Co-authored-by: Lukasz Rozmej <[email protected]> * Update src/Nethermind/Nethermind.State/WorldStateScopeOperationLogger.cs Co-authored-by: Lukasz Rozmej <[email protected]> * Update src/Nethermind/Nethermind.State/WorldStateScopeOperationLogger.cs Co-authored-by: Lukasz Rozmej <[email protected]> * Update src/Nethermind/Nethermind.State/WorldStateScopeOperationLogger.cs Co-authored-by: Lukasz Rozmej <[email protected]> * Update src/Nethermind/Nethermind.State/WorldStateScopeOperationLogger.cs Co-authored-by: Lukasz Rozmej <[email protected]> * Update src/Nethermind/Nethermind.State/WorldStateScopeOperationLogger.cs Co-authored-by: Lukasz Rozmej <[email protected]> --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: asdacap <[email protected]> Co-authored-by: Lukasz Rozmej <[email protected]> * fix: use GaugeMetric for PeerCandidateCount (#10004) * Fix IsTracing calculation by making it lazy (#10053) * Auto-update fast sync settings (#10055) Co-authored-by: rubo <[email protected]> * Merge package release workflows (#10049) * Fix/get logs optimization (#9923) * try fix * Fix tests * Try fix * Fix * Fix from & to * Fix block in the future * Fix build * Fix range in the future * Fix block range * to * Fix tests * Fix json rpc tests * Fix formatting * Fix blockchain tests * Fix suggestions * Fix tags * Remove address from AddressFilter * Fix tests * Fix address filter * Optimize Filter changes * fix * refactor * Apply suggestions from code review Co-authored-by: Nikita Mescheryakov <[email protected]> --------- Co-authored-by: Nikita Meshcheriakov <[email protected]> * fix: resource cleanup in BeaconHeadersSyncFeed (#10037) * fix: resource cleanup in BeaconHeadersSyncFeed * remove override * perf: avoid rlp encode-decode in simulate receipt recovery (#10021) * perf: avoid rlp encode-decode in simulate receipt recovery * fix * Fix CodeQL workflow (#10056) * Check for 0 in MOD opcode (#10061) Check for 0 in Mod * Keep EXP opcode in UInt256 domain (#10060) * Keep EXP opcode in UInt256 domain * Is bytes * fix: DataFeed constructor null checks (#10062) * Update schema (#10035) * Remove MetricsController._metricTypes (#10057) * Fixes #9577: resolve race condition in StateSyncFeedTests.Big_test (#9972) * fix(sync): resolve race condition in StateSyncFeedTests.Big_test (#9577) * fix(sync): Isolate block tree cache in StateSyncFeedTestsBase to fix parallel test failures * changes --------- Co-authored-by: Lukasz Rozmej <[email protected]> * Perf/TryGetDirtyNode (#10067) * Try get dirty child * Appendmut set last * Should be inside instead * Fix tracelog * Fix trace again * Call prune persisted recursively on commit and on copy too (#10065) * feat(abi): add support for fixed-size array element types (#10025) * XDC Reward handler (#9881) * calculator * state reader * masternode voting contract * fix * abi json * working load test * test * test * test getCandidates * cleanup * format * remove var * format * review comments * implement calculate rewards base flow and get signing txs * implement rewards per signer and distribution calculations * implement getCadidateOwner * refactors and add comments to the code * add block signer contract address to the configuration spec * implement reward module tests * implement hook for reward calculation in hotstuff pipeline * refactor and format * format * fix xdc test * wire IRewardClaculator in ConfigureContainer in XdcTestBlockchain * address review comments and add unit test with precalculated xdc reward values * add missing dependencies in Xdc module * fix resolving contract addresses from spec * fix error with WorldState after merge * add comments for reward tests with link to original source --------- Co-authored-by: ak88 <[email protected]> Co-authored-by: ak88 <[email protected]> * Use baseblock for tree visitor (#10066) * Surge: Fix Profitabilty Check Bypass (#10020) * add potential fix * nit: improve config description * Skip SST file size checks when MaxOpenFiles is specified (#10002) * Skip SST file size checks when MaxOpenFiles is specified * Add config option, skip SST checks on MacOS if not configured otherwise * Remove obvious comment * Fix: Correct memory access validation in TrySaveByte for MSTORE8 operation (#9970) * Update EvmPooledMemory.cs * Update src/Nethermind/Nethermind.Evm/EvmPooledMemory.cs Co-authored-by: Copilot <[email protected]> * Update src/Nethermind/Nethermind.Evm/EvmPooledMemory.cs * Update src/Nethermind/Nethermind.Evm/EvmPooledMemory.cs --------- Co-authored-by: Lukasz Rozmej <[email protected]> Co-authored-by: Copilot <[email protected]> * Update file header templates (#10077) * Should update child if parent has empty keccak as well (#10073) * Should update child if parent has empty keccak as well * Combine conditions * Improve FastHash quality (#10082) * Improve hash quality * formatting * Update src/Nethermind/Nethermind.Core/Extensions/SpanExtensions.cs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> * refactor: replace HexConvert.ToUInt256 with UInt256.Parse (#10085) Keep HexConvert.ToUInt64 as it handles both base 10 and 16 automatically. * fix: ensure eth_getBlockByNumber enforces canonical block retrieval (#10024) * fix: ensure eth_getBlockByNumber enforces canonical block retrieval * fix tests * address comment * apply suggestion * Auto-update fast sync settings (#10089) Co-authored-by: rubo <[email protected]> * fix: correct assertion variables in Cleans_invalid_blocks_before_starting test (#10086) Update BlockTreeTests.cs * Drop eth66 and eth67 support, add eth69 as a default (#9938) * Drop eth66 and eth67 support * Fix tests * test * bump versions * Fix E2ESyncTests failures when isPostMerge=false - remove eth/69 from default capabilities (#10103) * Initial plan * Remove eth/69 from default capabilities - added dynamically by MergePlugin Co-authored-by: benaadams <[email protected]> * Fix test expecting eth/69 as highest default protocol version Co-authored-by: benaadams <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: benaadams <[email protected]> * fix --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: benaadams <[email protected]> * fix(network): shutdown rlpx executor group (#10087) * feat (gas policy): add `ConsumeCodeCopyGas` method (#10068) * Add Address recovery from PublicKey to KeccakCache (#10003) * Add Address recovery from PublicKey to KeccakCache * Improve comments * Feedback * refactor: remove unused Destroy change type from storage provider (#10106) * Update to UInt256 version 1.4.0 (#10107) * Update to UInt256 version 1.4.0 * Fix some div zero * chore: remove debug-only keccak keys from proof call storage test (#10104) * fix: use parameter name in BloomStorage null check (#10096) * fix: correct ExampleResponse for admin_importHistory method (#10097) Update IEraAdminRpcModule.cs * fix: remove redundant blockInfosDb assertions (#10099) Update BlockTreeTests.cs * perf: reuse SimpleConsoleLogger instance in SimpleConsoleLogManager (#10070) Update SimpleConsoleLogManager.cs * optimize eth_gasPrice using kth algorithm (#10100) * optimize eth_gasPrice using kth algorithm * fix: review nethermind --------- Co-authored-by: weixie.cui <[email protected]> * Don't queue prunes (#10112) * Don't queue prunes * Add delay * Add Delay reasoning comment * refactor: simplify Avx2 branches for UInt256 shuffles (#10111) * refactor: simplify Avx2 branches for UInt256 shuffles * Update EvmStack.cs * fix(kute): prevent null label crash in Prometheus metrics reporter (#10109) * Fix #10068 regression (#10116) * Git/ignore claude config (#10118) * Ignore claude config in git * Ignore claude config in git * perf: use cached BlockInfo variable instead of redundant array access in BlockTree (#10125) Update BlockTree.cs * Save space locally on builds (#10113) * Add Directory.Build.targets with: - Skip copying dependencies and native runtimes for library projects - Filter native runtimes to current OS only during local builds - Share native runtimes across projects during local builds with a shared location and junctions/symlinks * NethermindCopyAllRuntimes -> CI * Remove filtering native lib by os * Move Directory.Build.targets to src/Nethermind * Make mechanism opt-in with SlimBuild parameter Add Directory.Build.targets to Solution Items * SlimBuild can have any value to be enabled * Refactor Directory.Build.targets (#10122) --------- Co-authored-by: Ruben Buniatyan <[email protected]> * Align Nethermind with the latest taiko-geth changes (#10127) * Surge TDX Attestation (#9954) * initial changes for taiko tdx * fixes and refactoring * optimize attestation * simplify attestation, return block header and add tests * add two variants for attestation, remove quotes & instance id, add tests * remove docs * minor fix * modify header attestation to return both hash and header rlp * refactor * fix tests and address comments * nit: fix whitespace * undo tdx module change * modify signature to use blockhash+stateroot * fix new header serialization * address comments --------- Co-authored-by: smartprogrammer93 <[email protected]> * Remove redundant `File.Delete` after `File.Move` (#10128) * refactor: simplify conditional returns in FeeTooLowFilter (#10129) * refactor: remove unused finalization manager field in Optimism plugin (#10130) * Optimize discv5 (#10081) * Update schema * Fix schema * No need in type cast * Use improved discv5; refactor * Update PierTwo.Lantern.Discv5.WireProtocol * Less errors * Pooled * refactor: remove unused `_pushEnabled` from MonitoringService (#10135) refactor: remove unused _pushEnabled from MonitoringService * Add some guards to RetryCache (#10134) * Add some guards to RetryCache Co-authored-by: Lukasz Rozmej <[email protected]> --------- Co-authored-by: Lukasz Rozmej <[email protected]> Co-authored-by: Marcos Antonio Maceo <[email protected]> * XDC save snapshot on gap block (#9774) * start * state reader * state reader * masternode voting contract * fix * blocktree saves snapshot on gap * abi json * working load test * test * test * test getCandidates * cleanup * format * update masternodes * hooked up with deposit contract * remove var * format * review comments * format * test rewrite * test fix * format * test save snapshot on head block * merge fix * cleanup * merge fix * merge fix * merge fix * remove using * remove class * fix MasternodeVotingContract IOC * perf: Remove redundant allocations in NettyDiscoveryHandlerTests (#10155) Update NettyDiscoveryHandlerTests.cs * fix: correct header range logging in PoW forward sync (#10140) Update PowForwardHeaderProvider.cs * fix: avoid GetReceiptData when hash lookup unsupported (#10023) Co-authored-by: Lukasz Rozmej <[email protected]> * fix: correct slice index in Address.TryParseVariableLength (#9902) * fix: correct slice index in Address.TryParseVariableLength * test * update test Co-authored-by: Lukasz Rozmej <[email protected]> * Update src/Nethermind/Nethermind.Core.Test/AddressTests.cs --------- Co-authored-by: Lukasz Rozmej <[email protected]> * perf(facade): optimize SimulateDictionaryHeaderStore.Get for cache hits (#9903) * fix: add informative message to block processing timeout exception (#9912) Update HiveRunner.cs * fix: Remove invalid eth_getTransactionByHash call (#9784) * Fix typos 2 (#10162) * Few typos fixed * Check in the pipeline * Apply suggestions from code review Co-authored-by: Copilot <[email protected]> * Remove * Some fixes * Test --------- Co-authored-by: Copilot <[email protected]> * fix: remove duplicate transaction processor adapter registration (#10170) * perf: avoid extra init code allocations in CREATE/EOFCREATE (#10019) * perf: avoid extra init code allocations in CREATE/EOFCREATE * perf: avoid extra init code allocations in CREATE/EOFCREATE * Replace empty array initializations with Array.Empty<T>() (#10172) * Initial plan * Replace empty array initializations with Array.Empty<T>() Co-authored-by: MarekM25 <[email protected]> * Replace new Address[0] with Array.Empty<Address>() in Xdc production code Co-authored-by: MarekM25 <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: MarekM25 <[email protected]> * Fix disposing of a pooled array (#10168) * fix(SendBlobs): add missing receiverOption to reclaim command (#10136) * Auto-update fast sync settings (#10179) Co-authored-by: rubo <[email protected]> * fix(sync): use INetworkConfig constructor for SyncPeerPool DI registration (#10158) * fix(sync): use INetworkConfig constructor for SyncPeerPool DI registration SyncPeerPool was ignoring the configured MaxActivePeers value and always using a hardcoded default of 100 peers. Root cause: SyncPeerPool has two constructors: 1. One taking INetworkConfig that reads ActivePeersMaxCount from config 2. One with default parameters (peersMaxCount = 100) The DI registration `.AddSingleton<SyncPeerPool>()` allowed Autofac to pick a constructor automatically. Autofac selected the constructor with default parameters, completely bypassing INetworkConfig. This caused SyncPeerPool.PeerMaxCount to always be 100 regardless of the configured Network.MaxActivePeers value. Fix: Use explicit factory registration that specifies INetworkConfig as a dependency, ensuring the correct constructor is called with config values. * refactor: use UseConstructorForDependencyInjection attribute and add test * refactor(tools): eliminate redundant First() calls in HiveConsensusWorkflowGenerator (#10182) Update Program.cs Co-authored-by: Lukasz Rozmej <[email protected]> * docs: fix dead link (#10181) Update ForkchoiceUpdatedV1Result.cs Co-authored-by: Lukasz Rozmej <[email protected]> * Remove redundant ToArray calls in eth_accounts (#10185) Co-authored-by: Lukasz Rozmej <[email protected]> * Override default CLI option alias (#10148) Co-authored-by: Ruben Buniatyan <[email protected]> * Add AGENTS.md (#10177) * Fix cannot prune storage root (#10203) * Fix cannot prune storage root * Fix whitespace formatting in TreeStoreTests.cs (#10204) * Initial plan * Fix whitespace formatting in TreeStoreTests.cs Co-authored-by: asdacap <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: asdacap <[email protected]> --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: asdacap <[email protected]> * Support CLI alias overrides in docs (#10197) * Fast-path ConcurrentDict AddOrUpdate (#10220) * Fast-path ConcurrentDict AddOrUpdate * Also debug * Reuse same nibble keys for short paths (#10214) * Reuse same nibble keys for short paths * Address review comments: remove unused parameter, add XML docs, add unit tests for GetPathArray (#10215) * Initial plan * Address review comments: remove unused parameter, add XML docs, add unit tests Co-authored-by: benaadams <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: benaadams <[email protected]> * formatting * Other places * formatting * More optimal * Add tests for PrependNibble and ConcatNibbles methods (#10216) * Initial plan * Add comprehensive tests for PrependNibble and ConcatNibbles methods Co-authored-by: benaadams <[email protected]> * Fix misleading comments in ConcatNibbles tests Co-authored-by: benaadams <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: benaadams <[email protected]> * Add validation checks to ConcatNibbles for invalid nibble values (#10217) * Initial plan * Add validation checks to ConcatNibbles for robustness Co-authored-by: benaadams <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: benaadams <[email protected]> * Update src/Nethermind/Nethermind.Trie/HexPrefix.cs Co-authored-by: Ruben Buniatyan <[email protected]> --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: benaadams <[email protected]> Co-authored-by: Ruben Buniatyan <[email protected]> * Update Dockerfiles (#10222) Co-authored-by: rubo <[email protected]> * Change async capturing closures to regular async methods (#10221) * Change async capturing closures to regular async methods * Formatting * Spelling * Reduce closure allocations in RetryCache (#10223) * Reduce closure allocations in RetryCache * Feedback * perf: Avoid unnecessary base fee calculations (#10213) * Update OP Superchain chains (#10178) Co-authored-by: emlautarom1 <[email protected]> Co-authored-by: Lukasz Rozmej <[email protected]> * Remove redundant static metadata from `CachedPrecompile` wrapper (#10225) Update CachedCodeInfoRepository.cs Co-authored-by: Lukasz Rozmej <[email protected]> * refactor: extract duplicate chain ID retrieval logic in SendBlobs CLI (#10150) Update SetupCli.cs * perf: avoid eager client id formatting in ZeroNettyP2PHandler (#10189) * perf: avoid eager client id formatting in ZeroNettyP2PHandler * Update src/Nethermind/Nethermind.Network/P2P/ProtocolHandlers/ZeroNettyP2PHandler.cs Co-authored-by: Lukasz Rozmej <[email protected]> * add GetClientId and remove duplication * Apply suggestions from code review * Apply suggestion from @LukaszRozmej --------- Co-authored-by: Lukasz Rozmej <[email protected]> * fix: align storage tracing flag for ReportStorageChange (#10201) Co-authored-by: Lukasz Rozmej <[email protected]> * fix(test-runner): Use maxPriorityFeePerGas for EIP-1559 state test parsing (#10205) For EIP-1559+ transactions, GasPrice is aliased to MaxPriorityFeePerGas in go-ethereum. When parsing state tests, use maxPriorityFeePerGas from JSON when available, falling back to maxFeePerGas if not specified. This aligns Nethermind's state test parsing behavior with go-ethereum. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <[email protected]> Co-authored-by: Alexey Osipov <[email protected]> Co-authored-by: Lukasz Rozmej <[email protected]> * fix: gRPC client reconnect to shutdown previous channel (#10156) * fix: gRPC client reconnect to shutdown previous channel * Update src/Nethermind/Nethermind.Grpc/Clients/GrpcClient.cs Co-authored-by: Lukasz Rozmej <[email protected]> * Update src/Nethermind/Nethermind.Grpc/Clients/GrpcClient.cs --------- Co-authored-by: Lukasz Rozmej <[email protected]> * perf: eliminate redundant allocations in SendData byte normalization (#10154) Update BlobSender.cs * refactor: split ClHealthTrackerTests into separate test methods (#10171) * Update ClHealthTrackerTests.cs * Update ClHealthTrackerTests.cs --------- Co-authored-by: Lukasz Rozmej <[email protected]> * Optimize `PathUtils` (#10219) * Use `ConcurrentDictionary.GetOrAdd` in `Session` to avoid manual get-or-add logic (#10229) Update Session.cs * Allow some delays to be configurable (#10227) * Allow some delays to be configurable * Always async * Formatting * Update src/Nethermind/Nethermind.Merge.Plugin/IMergeConfig.cs Co-authored-by: Ruben Buniatyan <[email protected]> * Update src/Nethermind/Nethermind.Db/IPruningConfig.cs Co-authored-by: Ruben Buniatyan <[email protected]> --------- Co-authored-by: Ruben Buniatyan <[email protected]> * Schedule largest storage changes first (#10236) * Schedule largest storage changes first * Feedback * fix: SyncDispatcher leak by disposing CountdownEvent (#10240) * Move default implementations out of IReleaseSpec (#10237) * Move default implementations out of IReleaseSpec * fix some test * Update src/Nethermind/Nethermind.Core/Specs/IReleaseSpecExtensions.cs Co-authored-by: Copilot <[email protected]> * fix more tests * Cleanup ISpecProvider.GetSpec * fix test * less whitespace --------- Co-authored-by: Copilot <[email protected]> * Fix `PathUtils` for JetBrains Rider (#10238) * Apply a workaround for JetBrains Rider * Don't use `System.Diagnostics` * Fix formatting * Optimize storage key handling (#10241) * Optimize storage key handling Replaces byte[] with ValueHash256 for storage key lookup and computation in StorageTree for improved type safety and performance. Updates related method signatures and usages to use ValueHash256. Adds [SkipLocalsInit] attribute to several performance-critical methods in trie and pruning code. * Feedback * fix: avoid mutating levels in header/body existence checks (#10157) * fix: Add missing fields to Transaction.CopyTo and PoolPolicy.Return (#9890) Co-authored-by: Lukasz Rozmej <[email protected]> * Consider genesis in processing and finalization (#10235) * Refactor/Allow metrics before block processing (#10076) * Invert metric dependencies * Use timer loop * Rename metrics updater * Comment * Reduce change * Reduce change * Unit tests * Some cleanup * Fix dependencies * Add missing file header * Update src/Nethermind/Nethermind.Init/Modules/MonitoringModule.cs Co-authored-by: Lukasz Rozmej <[email protected]> * Update src/Nethermind/Nethermind.Init/Steps/EthereumStepsManager.cs Co-authored-by: Lukasz Rozmej <[email protected]> * Split the monitoring module out * Use BlockEventArgs * Whitespace * Address PR review comments: fix comment and remove unused method (#10084) * Initial plan * Address PR review comments: update comment and remove StopAsync Co-authored-by: asdacap <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: asdacap <[email protected]> * Move db monitoring outside * Fix build * [WIP] Refactor to allow metrics before block processing (#10186) * Initial plan * Fix filename format issue: remove trailing space from IMonitoringService.cs Co-authored-by: asdacap <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: asdacap <[email protected]> * Does this fix format? --------- Co-authored-by: Ruben Buniatyan <[email protected]> Co-authored-by: Lukasz Rozmej <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: asdacap <[email protected]> * Fix maybe combine logic fetch child with wrong path. (#10145) * Fix maybe combine logicc missed a fetch node * Fix typo in test class name: StrictRawScopedTrieStoce → StrictRawScopedTrieStore (#10146) * Initial plan * Fix typo in class name: StrictRawScopedTrieStoce -> StrictRawScopedTrieStore Co-authored-by: asdacap <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: asdacap <[email protected]> --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: asdacap <[email protected]> * Feature/RocksDb Snapshot (#10080) * Snapshot support * Move logic to db reader * Ensure get is used * Add comment on verify checksum * Format * Address PR #10080 review comments: fix memory leaks, improve documentation, add safety checks (#10083) * Initial plan * Address review comments: fix docs, memory leaks, and add safety checks Co-authored-by: asdacap <[email protected]> * Remove unused _readOptions field from RocksdbSortedView Co-authored-by: asdacap <[email protected]> * Use discard pattern for unused readOptions parameter Co-authored-by: asdacap <[email protected]> * Remove unnecessary readOptions parameter from RocksdbSortedView Co-authored-by: asdacap <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: asdacap <[email protected]> * Make nullable --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: asdacap <[email protected]> * Bump default pruning cache by 512MB for larger mainnet blocks (#10247) Bump default pruning cache by 512MB * Fix: Change Taiko RPC Response to PascalCase (#10244) change case * perf(clique): eliminate redundant cache lookup in GetBlockSealer (#10252) Update SnapshotManager.cs * Skip GC when pruning (#10230) * Skip GC when pruning * fix * feedback * Auto-update fast sync settings (#10260) Co-authored-by: rubo <[email protected]> * Update OP Superchain chains (#10261) Co-authored-by: emlautarom1 <[email protected]> * Fix/shared blockcache not used (#10263) * Cleaner optimize for hits * Columns db snapshot * Fix block cache * Fix test * Fix test * Fix build * Spell fix * Refactor HyperClockCacheWrapper to use SafeHandle pattern (#10265) * Initial plan * Refactor HyperClockCacheWrapper to use SafeHandle pattern Co-authored-by: asdacap <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: asdacap <[email protected]> --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: asdacap <[email protected]> * ColumnsDb snapshot (#10262) * ColumnsDb snapshot * Apply PR feedback: use NotSupportedException and simplify lambda syntax (#10264) * Initial plan * Apply PR feedback: use NotSupportedException and simplify lambda syntax Co-authored-by: asdacap <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: asdacap <[email protected]> --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: asdacap <[email protected]> * Refactor ReleaseSpec (#10251) * Add taiko debug RPC for integration test support (#10211) * Add taikoAuth_waitForTxPoolSync method * Revert unnecessary changes * Update src/Nethermind/Nethermind.TxPool/ITxPool.cs * Update src/Nethermind/Nethermind.TxPool/TxPool.cs * Update src/Nethermind/Nethermind.TxPool/HashCache.cs * Resolve comments * Simplify, remove needless logic, and rename * Resolve comments --------- Co-authored-by: Ahmad Bitar <[email protected]> * feat(tracing): enable external tracer registration and VM inheritance (#10228) * Re-enable prewarmer tx adapter for state pre-warming (#10266) Enable prewarmer tx adapter for state pre-warming * Validate state test tx as part of a block (#10224) * Add basic block validation to state tests * Some cleanup * Fix review * Add ProgressLogger to trie verification and full pruning operations (#10273) * docs: add implementation plan for ProgressLogger trie visitor integration Addresses #8504 - More use of ProgressLogger Detailed step-by-step plan with: - VisitorProgressTracker class implementation - Unit tests for thread-safety and accuracy - Integration into CopyTreeVisitor and TrieStatsCollector Co-Authored-By: Claude Opus 4.5 <[email protected]> * feat(trie): add VisitorProgressTracker for path-based progress estimation Addresses #8504 - More use of ProgressLogger - Tracks visited path prefixes at 4 levels (16 to 65536 granularity) - Thread-safe for concurrent traversal - Estimates progress from keyspace position, not node count Co-Authored-By: Claude Opus 4.5 <[email protected]> * test(trie): add unit tests for VisitorProgressTracker Tests cover: - Progress tracking at different levels - Thread-safety with concurrent calls - Monotonically increasing progress - Edge cases (short paths, empty path) Co-Authored-By: Claude Opus 4.5 <[email protected]> * feat(pruning): integrate VisitorProgressTracker into CopyTreeVisitor Replaces manual every-1M-nodes logging with path-based progress estimation. Progress now shows actual percentage through the keyspace. Co-Authored-By: Claude Opus 4.5 <[email protected]> * Improve TrieStatsCollector progress display - Always enable progress tracking in TrieStatsCollector - Add custom formatter to show node count instead of block speed - Track max reported progress to prevent backwards jumps - Display format: "Trie Verification 12.34% [...] nodes: 1.2M" Fixes progress display issues where: - Progress would jump backwards (12% → 5%) due to granularity switching - Showed confusing "Blk/s" units for trie operations - Displayed "11 / 100 (11.00%)" format that looked odd Co-Authored-By: Claude Sonnet 4.5 <[email protected]> * docs: remove implementation plan documents Implementation is complete, no need for plan docs in the codebase. Co-Authored-By: Claude Sonnet 4.5 <[email protected]> * Track both state and storage nodes in progress display The node count now includes both state and storage nodes, providing a more accurate representation of total work done. Progress estimation still uses state trie paths only. Changes: - Add _totalWorkDone counter for display (state + storage nodes) - Add isStorage parameter to OnNodeVisited() - Always increment total work, only track state nodes for progress Co-Authored-By: Claude Sonnet 4.5 <[email protected]> * Optimize progress tracking with active level and startup delay Improvements: - Add 1 second startup delay before logging to prevent early high values from getting stuck in _maxReportedProgress - Only track the deepest level with >5% coverage (active level) - Stop incrementing counts for shallower levels once deeper level has significant coverage - This ensures progress never shows less than 5% and provides more accurate granularity Technical changes: - Add _activeLevel field to track current deepest significant level - Add _startTime field and skip logging for first second - Only increment seen counts at active level or deeper - Automatically promote to deeper level when >5% coverage reached Co-Authored-By: Claude Sonnet 4.5 <[email protected]> * Simplify progress tracking to only use level 3 with leaf estimation Changed to a much simpler approach as requested: - Only track progress at level 3 (4 nibbles = 65536 possible nodes) - For nodes at depth 4: increment count by 1 - For LEAF nodes at shallower depths: estimate coverage - Depth 1: covers 16^3 = 4096 level-3 nodes - Depth 2: covers 16^2 = 256 level-3 nodes - Depth 3: covers 16^1 = 16 level-3 nodes - Non-leaf nodes at shallow depths: don't count (will be covered by deeper nodes) - Keep 1 second startup delay to prevent early high percentages This assumes the top of the tree is dense and provides accurate progress estimation based on actual trie structure. Updated tests to mark nodes as leaves where appropriate. Co-Authored-By: Claude Sonnet 4.5 <[email protected]> * Fix full pruning progress tracking - Pass isStorage and isLeaf parameters in CopyTreeVisitor - Storage nodes no longer contribute to state trie progress estimation - Leaf nodes at shallow depths now correctly estimate coverage - Increase startup delay to 5 seconds AND require at least 1% progress - Prevents early high estimates from getting stuck in _maxReportedProgress This fixes the issue where full pruning progress would immediately jump to 100% and not show meaningful progress during the copy operation. Co-Authored-By: Claude Sonnet 4.5 <[email protected]> * Simplify VisitorProgressTracker to single-level tracking Since we only track level 3 (4 nibbles), remove unnecessary array structure: - Replace int[][] _seen with int[] _seen (65536 entries) - Replace int[] _seenCounts with int _seenCount - Replace int[] MaxAtLevel with const int MaxNodes - Rename MaxLevel to Level3Depth for clarity This reduces memory allocation from 70,304 ints (16+256+4096+65536) to just 65,536 ints, and makes the code clearer. Co-Authored-By: Claude Sonnet 4.5 <[email protected]> * Remove unnecessary _seen array from VisitorProgressTracker Since OnNodeVisited is only called once per path, we don't need to track which prefixes we've seen. Just increment _seenCount directly. This eliminates the 65536-int array, reducing memory from 262KB to just a few counters. Co-Authored-By: Claude Sonnet 4.5 <[email protected]> * Remove _maxReportedProgress and allow progress to reverse - Remove _maxReportedProgress field and backwards-prevention logic - Report actual progress value even if it goes backwards - Fix path.Length check: only count nodes at exactly Level3Depth - Ignore nodes at depth > Level3Depth for progress calculation - Simplify comment about startup delay Progress should reflect reality, not be artificially constrained. Co-Authored-By: Claude Sonnet 4.5 <[email protected]> * Fix lint --------- Co-authored-by: Claude Opus 4.5 <[email protected]> * feat: enable taiko client CI integration tests (#10043) * feat: enable taiko client ci integration tests * fix: gh action structure to run l2_nmc locally * feat: add path for ci-taiko file * Update GitHub Actions checkout reference surge-taiko-mono * Merge conflicts * spelling --------- Co-authored-by: bigbear <[email protected]> Co-authored-by: ANtutov <[email protected]> Co-authored-by: Lukasz Rozmej <[email protected]> Co-authored-by: Fibonacci747 <[email protected]> Co-authored-by: Justin <[email protected]> Co-authored-by: oxBoni <[email protected]> Co-authored-by: Snezhkko <[email protected]> Co-authored-by: MozirDmitriy <[email protected]> Co-authored-by: Diptanshu Kakwani <[email protected]> Co-authored-by: Bashmunta <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Nikita Mescheryakov <[email protected]> Co-authored-by: VolodymyrBg <[email protected]> Co-authored-by: sashass1315 <[email protected]> Co-authored-by: Marcos Antonio Maceo <[email protected]> Co-authored-by: core-repository-dispatch-app[bot] <173070810+core-repository-dispatch-app[bot]@users.noreply.github.com> Co-authored-by: rubo <[email protected]> Co-authored-by: emlautarom1 <[email protected]> Co-authored-by: Forostovec <[email protected]> Co-authored-by: Merkel Tranjes <[email protected]> Co-authored-by: phrwlk <[email protected]> Co-authored-by: Bilog WEB3 <[email protected]> Co-authored-by: Alexey Osipov <[email protected]> Co-authored-by: …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Manually verified that SyncPeerPool.PeerMaxCount now matches Network.MaxActivePeers config value. Previously, the DI container was selecting the constructor with default parameter
peersMaxCount = 100, causing the config to be ignored.Documentation
Requires documentation update
Requires explanation in Release Notes
SyncPeerPool now correctly respects the configured
Network.MaxActivePeersvalue. Previously, it always used a hardcoded default of 100 peers regardless of configuration due to incorrect DI constructor selection.Remarks
Root cause: SyncPeerPool has two constructors - one taking INetworkConfig and one with default parameters (
peersMaxCount = 100). The.AddSingleton<SyncPeerPool>()registration allowed Autofac to pick a constructor automatically, and it selected the one with defaults, bypassing INetworkConfig entirely.Fix: Changed to explicit factory registration that specifies INetworkConfig as a dependency.