Skip to content

perf: eliminate redundant allocations in SendData byte normalization #10154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukaszRozmej merged 1 commit into from
Jan 14, 2026
Merged

perf: eliminate redundant allocations in SendData byte normalization #10154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions tools/SendBlobs/BlobSender.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,18 @@ public async Task SendData(
bool waitForInclusion,
IReleaseSpec spec)
{
data = data
.Select((s, i) => i % 32 != 0 ? [s] : (s < 0x73 ? new byte[] { s } : [(byte)(32), s]))
.SelectMany(b => b).ToArray();
int capacity = data.Length + data.Length / 32; // at most one extra byte per 32-byte chunk
List<byte> normalized = new(capacity);
for (int i = 0; i < data.Length; i++)
{
byte value = data[i];
if (i % 32 == 0 && value >= 0x73)
{
normalized.Add(32);
}
normalized.Add(value);
}
data = normalized.ToArray();
Comment on lines +208 to +218
Copy link
Member

@LukaszRozmej LukaszRozmej Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory we could do 2 scans, one to calculate length and the other to do actual normalization. This way we could just allocate array and avoid allocating list.

But this is just BlobSender, so probably performance and GC pressure are not that crucial


if (waitForInclusion)
{
Expand Down