Skip to content

Arbitrum EIP-2935 historical block hashes #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svlachakis merged 3 commits into from
Jan 30, 2026
Merged

Arbitrum EIP-2935 historical block hashes #606

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07adf92
remove unneccesary if
svlachakis Jan 29, 2026
ca1ea13
Merge branch 'main' into 510-historical-blockhash
svlachakis Jan 29, 2026
93c53f0
skip possible null reference
svlachakis Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/Nethermind.Arbitrum/Execution/ArbitrumTransactionProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,23 +469,19 @@ private ArbitrumTransactionProcessorResult ProcessArbitrumInternalTransaction(
prevHash = blCtx.Header.ParentHash!;
}

if (_arbosState!.CurrentArbosVersion >= ArbosVersion.ParentBlockHashSupport)
{
}

Dictionary<string, object> callArguments =
AbiMetadata.UnpackInput(AbiMetadata.StartBlockMethod, tx.Data.ToArray());

ulong l1BlockNumber = (ulong)callArguments["l1BlockNumber"];
ulong timePassed = (ulong)callArguments["timePassed"];

if (_arbosState.CurrentArbosVersion < ArbosVersion.Three)
if (_arbosState!.CurrentArbosVersion < ArbosVersion.Three)
{
// (incorrectly) use the L2 block number instead
timePassed = (ulong)callArguments["l2BlockNumber"];
}

if (_arbosState.CurrentArbosVersion < ArbosVersion.Eight)
if (_arbosState!.CurrentArbosVersion < ArbosVersion.Eight)
{
// in old versions we incorrectly used an L1 block number one too high
l1BlockNumber++;
Expand Down