System Tests - Dynamically Parameterized Chainspec#550
Merged
damian-orzechowski merged 6 commits intomainfrom Jan 14, 2026
Merged
System Tests - Dynamically Parameterized Chainspec#550damian-orzechowski merged 6 commits intomainfrom
damian-orzechowski merged 6 commits intomainfrom
Conversation
svlachakis
requested review from
AnkushinDaniil,
damian-orzechowski,
hudem1 and
wurdum
as code owners
wurdum
approved these changes
Jan 13, 2026
AnkushinDaniil
approved these changes
Jan 13, 2026
Collaborator
Author
|
@wurdum @AnkushinDaniil please review again, added dynamically parameterized chainspec for system tests |
Merged
svlachakis
changed the title
Contributor
Minimum allowed line rate is |
damian-orzechowski
approved these changes
Jan 14, 2026
AnkushinDaniil
added a commit
that referenced
this pull request
Jan 14, 2026
PR #550 introduced naming mismatches between the script defaults and actual file names: - Template path: chainspec.template → system-test-chainspec.template - Accounts default: default.json → defaults.json These mismatches caused the script to fail when invoked via `make generate-system-test-config` or directly.
AnkushinDaniil
added a commit
that referenced
this pull request
Jan 14, 2026
PR #550 introduced naming mismatches between the script defaults and actual file names: - Template path: chainspec.template → system-test-chainspec.template - Accounts default: default.json → defaults.json These mismatches caused the script to fail when invoked via `make generate-system-test-config` or directly.
AnkushinDaniil
added a commit
that referenced
this pull request
Jan 19, 2026
PR #550 introduced naming mismatches between the script defaults and actual file names: - Template path: chainspec.template → system-test-chainspec.template - Accounts default: default.json → defaults.json These mismatches caused the script to fail when invoked via `make generate-system-test-config` or directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to revert prefunded account because it affects state of other system tests.
Need to come up with a different way, easiest solution for now is to have a separate chainspec for this specific test but that's not scalable if it needs to happen in more tests.
Test that needs this account NethermindEth/arbitrum-nitro#52
Solution : Added dynamically parameterized chainspec for System Tests
Supported Parameters for System Tests needed so far: