-
Notifications
You must be signed in to change notification settings - Fork 0
Arbitrum Precompiles Extension Implementation through IReleaseSpec #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AnkushinDaniil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 👍
|
Let's wait for this discussion to be resolved. I think the current solution can be improved. |
|
This still has the old approach - converting to draft until NethermindEth/nethermind#9222 get's merged and I update it. |
| && data[3] == 0 && data[2] == 0 && data[1] == 0 && data[0] == 0 | ||
| && (data[4] >>> 24) switch | ||
| { | ||
| 0x64 => true, // ArbSys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the new approach, i think it makes sense we register all our precompiles?
at least ArbGasInfo too for sure as block 1847 needs that fix for the ArbGasInfo precompile too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't register all blindly from Arbitrum docs because they create problems. ArbGasInfo yes for sure.
|
that's the PR for the new approach |
Fixes Resolve #167
Summary
Implemented an extensible precompile architecture using IReleaseSpec.Precompiles property with lazy initialization and BuildPrecompilesCache() method, enabling chain-specific precompile support for Arbitrum and other L2 networks.
Dependencies
NethermindEth/nethermind#9222