fix HTTPRequestUtils.getRequestHeaderMap #394
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, but can you please add a test to exercise the different branches of logic there. |
artgon
reviewed
Jan 12, 2018
| while (values.hasMoreElements()){ | ||
| Object value = values.nextElement(); | ||
| if (value == null){ | ||
| continue; |
There was a problem hiding this comment.
Instead of continuing, you can do the inverse of the if statement and add it then. It'll make the code more readable. You can replace all of the continues that way.
| @@ -185,7 +185,7 @@ void initZuul() throws Exception, IllegalAccessException, InstantiationException | |||
|
|
|||
| LOG.info("Starting Groovy Filter file manager"); | |||
| final AbstractConfiguration config = ConfigurationManager.getConfigInstance(); | |||
|
|
|||
| Thread.sleep(40000); | |||
There was a problem hiding this comment.
What is this for?
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix HTTPRequestUtils.getRequestHeaderMap