Closed
Conversation
kylophone
reviewed
Jun 23, 2020
| extern VmafFeatureExtractor vmaf_fex_float_adm; | ||
| extern VmafFeatureExtractor vmaf_fex_float_vif; | ||
| extern VmafFeatureExtractor vmaf_fex_integer_motion; | ||
| extern VmafFeatureExtractor vmaf_fex_integer_motion2; |
Collaborator
There was a problem hiding this comment.
If #594 is merged, I don't think it makes sense to rename these *_motion2, since they provide both. We could also use the same feature extractor for motion3 in the future.
Collaborator
|
See my inline comment. Also, squash before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.