Ensure JobActor has JobID as part of every emitted log line #384 #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ue5wu
requested review from
nickmahilani,
jeffchao,
piygoyal,
calvin681,
sundargates,
Andyz26,
hmitnflx,
markcho,
liuml07 and
fdc-ntflx
as code owners
7ue5wu
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
7ue5wu
had a problem deploying
to
Integrate Pull Request
GitHub Actions
Failure
sundargates
reviewed
Apr 4, 2023
| // UNEXPECTED MESSAGES END // | ||
| .match(Terminated.class, this::onTerminated) | ||
| .matchAny(x -> { | ||
| MDC.put("name", name); |
There was a problem hiding this comment.
Doesn't this make assumptions about the thread context? Will these assumptions be held for Akka actors?
There was a problem hiding this comment.
Oh, I didn't consider it. So does it mean it is better to use ActorContext.getLog() to obtain the logger and clear the MDC after processing the current message?
There was a problem hiding this comment.
I don't think we want to use MDC for this.
There was a problem hiding this comment.
It seems I thought it the wrong way. Thank you for telling me and I will fix it after my busy final.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Logger adds the jobID to every emitted logline by default.
Checklist
./gradlew buildcompiles code correctly./gradlew testpasses all tests