Add sanity check on attachment filename

genie-web/src/main/java/com/netflix/genie/web/exceptions/checked/IllegalAttachmentFileNameException.java

@@ -1,9 +1,27 @@
+/*
+ *
+ *  Copyright 2020 Netflix, Inc.
+ *
+ *     Licensed under the Apache License, Version 2.0 (the "License");
+ *     you may not use this file except in compliance with the License.
+ *     You may obtain a copy of the License at
+ *
+ *         http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *     Unless required by applicable law or agreed to in writing, software
+ *     distributed under the License is distributed on an "AS IS" BASIS,
+ *     WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *     See the License for the specific language governing permissions and
+ *     limitations under the License.
+ *
+ */
 package com.netflix.genie.web.exceptions.checked;
 
 /**
  * Exception thrown when the attachment filename is illegal.
  *
  * @author bhou
+ * @since 4.0.0
  */
 public class IllegalAttachmentFileNameException extends SaveAttachmentException {
     /**

genie-web/src/test/groovy/com/netflix/genie/web/services/impl/LocalFileSystemAttachmentServiceImplSpec.groovy

@@ -155,8 +155,8 @@ class LocalFileSystemAttachmentServiceImplSpec extends Specification {
     }
 
     def "reject attachments with illegal filename"() {
-        Set<Resource> attachments = Sets.newHashSet()
-        Resource attachment = Mock(Resource)
+        Set<Resource> attachments = new HashSet<Resource>()
+        Resource attachment = Mockito.mock(Resource.class)
         Mockito.doReturn("../../../root/breakout.file").when(attachment).getFilename()
         attachments.add(attachment)