Remove prototype function usage, fixes #8. #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ND_PROTOTYPES = false
jayphelps
changed the title
|
@Blesh reset to upstream/master and re-did watson. Should be good now. It made some stylistic choices about putting calls with lots of args on new lines but I'm personally not against it. |
benlesh
added a commit
that referenced
this pull request
Apr 10, 2015
Remove prototype function usage, fixes #8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8.
Work in progress as ember-watson was awesome, but this project (ember-cli-nf-graph) has a mix of spaces/tabs (even within the same file) and so the output formatting got wonky in certain parts, though it doesn't impact how it functions. I've already started fixing them, should be done soon.From the looks of things, I think it's safe to assume this project prefers 2 space instead of tabs (likely older code was in tabs) and regardless, ember-watson assumes spaces anyway right now.Ready.