Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui(mfa): dont require button click to validate mfa, do automatically #5448

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

wssheldon
Copy link
Contributor

@wssheldon wssheldon commented Nov 8, 2024

What does this PR do?

Remove button you have to click on/mfa to complete the flow.

Clicking the button to validate MFA is unnecessary, being able to navigate to the page is enough.

How did you verify your code works?

I wrote component level tests.

 ✓ src/tests/Mfa.spec.js (6)
   ✓ mounts correctly and starts verification automatically
   ✓ shows loading state while verifying
   ✓ shows success message and closes window on approval
   ✓ shows error message and retry button on denial
   ✓ retry button triggers new verification attempt
   ✓ handles API errors gracefully

 Test Files  1 passed (1)
      Tests  6 passed (6)
   Start at  09:11:58
   Duration  391ms

I manually test the new flow, end to end.

Screenshot 2024-11-08 at 9 15 37 AM

@wssheldon wssheldon added enhancement New feature or request javascript Pull requests that update Javascript code labels Nov 8, 2024
@wssheldon wssheldon self-assigned this Nov 8, 2024
Copy link
Contributor

@kevgliss kevgliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, aligns with how stairmaster does it as well.

@wssheldon wssheldon changed the title ui(mfa): dont require link click to validate mfa, do automatically ui(mfa): dont require button click to validate mfa, do automatically Nov 8, 2024
@wssheldon wssheldon merged commit 2f17948 into master Nov 8, 2024
9 checks passed
@wssheldon wssheldon deleted the ui/mfa-auth branch November 8, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants