Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scheduler): weekly reports should run weekly #5317

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

whitdog47
Copy link
Contributor

@whitdog47 whitdog47 commented Oct 9, 2024

This PR fixes the weekly incident report to run weekly instead of daily. Also ensured that an empty report wasn't sent in the case of all restricted incidents for that week, instead a notice is sent that indicates there were no incidents to report on.

@whitdog47 whitdog47 added the bug Something isn't working label Oct 9, 2024
@whitdog47 whitdog47 self-assigned this Oct 9, 2024
@whitdog47 whitdog47 marked this pull request as ready for review October 9, 2024 23:46
src/dispatch/incident/scheduled.py Outdated Show resolved Hide resolved
@whitdog47 whitdog47 merged commit 2d5a5b4 into master Oct 10, 2024
9 checks passed
@whitdog47 whitdog47 deleted the bugfix/weekly-reports-run-weekly branch October 10, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants