-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaces hyperlinks in a specified Google Doc. #4375
Replaces hyperlinks in a specified Google Doc. #4375
Conversation
It would be relatively easy to unit test the three functions involved here, we can mock response of content from google. I think this would be a good thing to add for this change. |
Co-authored-by: Will Sheldon <[email protected]>
…d return values. Defines parameter types.
…cases for helper method.
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
For these external service API tests where we don't control the response we can consider using vrcpy in the future so they're more maintainable. |
If the url of a hyperlink contains a placeholder, it will be replaced with the corresponding value in a replacements list.
For example, if we aim to substitute all instances of
{{name}}
in a Google Doc withnetflix
, a hyperlink that originally directed tohttp://www.{{name}}.com
will be transformed intohttp://www.netflix.com