Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces hyperlinks in a specified Google Doc. #4375

Merged
merged 14 commits into from
Feb 12, 2024

Conversation

metroid-samus
Copy link
Contributor

If the url of a hyperlink contains a placeholder, it will be replaced with the corresponding value in a replacements list.

For example, if we aim to substitute all instances of {{name}} in a Google Doc with netflix, a hyperlink that originally directed to http://www.{{name}}.com will be transformed into http://www.netflix.com

@metroid-samus metroid-samus added the enhancement New feature or request label Feb 8, 2024
@wssheldon
Copy link
Contributor

It would be relatively easy to unit test the three functions involved here, we can mock response of content from google. I think this would be a good thing to add for this change.

@metroid-samus
Copy link
Contributor Author

It would be relatively easy to unit test the three functions involved here, we can mock response of content from google. I think this would be a good thing to add for this change.

Done.

Copy link
Contributor

@wssheldon wssheldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@wssheldon
Copy link
Contributor

For these external service API tests where we don't control the response we can consider using vrcpy in the future so they're more maintainable.

@metroid-samus metroid-samus merged commit cb4b1d1 into master Feb 12, 2024
8 checks passed
@metroid-samus metroid-samus deleted the enhancement/add-hyperlinks-to-google-docs branch February 12, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants