-
Notifications
You must be signed in to change notification settings - Fork 558
Auto-run workflows associated with Signals and auto-parameterize with Entity Type values #3128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevgliss
reviewed
Mar 20, 2023
* Improving signal api
wssheldon
commented
Mar 23, 2023
kevgliss
approved these changes
Mar 24, 2023
wssheldon
commented
Mar 24, 2023
@@ -103,7 +103,7 @@ def test_filter_actions_deduplicate(session, signal, project): | |||
assert signal_instance_2.filter_action == SignalFilterAction.deduplicate | |||
|
|||
|
|||
def test_filter_actions_snooze(session, signal, project): | |||
def test_filter_actions_snooze(session, entity, signal, project): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevgliss FYI
to resolve:
psycopg2.errors.UniqueViolation: duplicate key value violates unique constraint "entity_pkey"
DETAIL: Key (id)=(10) already exists.
In case there's some deeper issue I am not seeing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We parameterize workflows/notebooks with values from entities by assigning the entity type name as the parameter value and then checking if that name exists in the entities for a consumed signal.
Configure Workflows for a Signal Definition
Create Workflows using Entity Types in a Dialog