Adds testing to signal instance creation #3077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wssheldon
reviewed
Mar 8, 2023
| external_id=signal_instance_data["id"], | ||
| variant=signal_instance_data.variant, | ||
| external_id=signal_instance_data.get("id"), | ||
| variant=signal_instance_data["variant"], |
There was a problem hiding this comment.
should it be .get("variant") since it's optional field?
There was a problem hiding this comment.
I think so, technically it's one or the other, I think we may need to eventually re-add something like raw signal back and enforce either 'id' or 'variant' (otherwise we can't do anything with it). But I need to figure out how to add arbitrary keys in a pydantic model (if that's even possible).
I'm going to merge this for the time being until I can figure that out.
rutvijmehta-harness
pushed a commit
to rutvijmehta-harness/dispatch
that referenced
this pull request
Mar 17, 2023
* Adds testing to signal instance creation * Adds to tags to update model * Fixing tests
rutvijmehta-harness
added a commit
to rutvijmehta-harness/dispatch
that referenced
this pull request
Mar 17, 2023
* Adds testing to signal instance creation * Adds to tags to update model * Fixing tests Co-authored-by: kevgliss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.