Remove mocking module #2086
Merged
Remove mocking module #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbakker
requested review from
kilink,
srinivasankavitha,
iuliiasobolevska,
kzwang,
asibross,
iparadiso and
jjacobs44
as code owners
…plicit use of this class in tests.
paulbakker
force-pushed
the
feature/remove-mocking-module
branch
from
a95aecf to
c9111ce
Compare
| @@ -71,7 +69,7 @@ import org.springframework.core.io.support.ResourcePatternUtils | |||
| import org.springframework.util.ReflectionUtils | |||
| import java.io.IOException | |||
| import java.lang.reflect.Method | |||
| import java.util.Optional | |||
| import java.util.* | |||
There was a problem hiding this comment.
extra nit: revert back
iparadiso
approved these changes
Dec 14, 2024
srinivasankavitha
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mocking module was the first functionality of the framework even before the framework really existed. While it seemed like an interesting idea, it never really panned out and is mostly unused.
Since we're removing a lot of legacy in the upcoming release, I want to remove this module as well.