Convert graphql-java validation errors to TypedGraphQL error #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsistent with our other error handling.
tinnou
reviewed
May 7, 2024
graphql-dgs/src/main/kotlin/com/netflix/graphql/dgs/internal/ValidationErrorInstrumentation.kt
Outdated
Show resolved
Hide resolved
tinnou
reviewed
May 7, 2024
graphql-dgs/src/main/kotlin/com/netflix/graphql/dgs/internal/ValidationErrorInstrumentation.kt
Outdated
Show resolved
Hide resolved
tinnou
reviewed
May 7, 2024
graphql-dgs/src/main/kotlin/com/netflix/graphql/dgs/internal/ValidationErrorInstrumentation.kt
Outdated
Show resolved
Hide resolved
tinnou
reviewed
May 9, 2024
| } else if (error.errorType == graphql.ErrorType.OperationNotSupported) { | ||
| val graphqlErrorBuilder = TypedGraphQLError | ||
| .newBuilder() | ||
| .errorType(ErrorType.UNAVAILABLE) |
There was a problem hiding this comment.
unavailable is like 503 right, maybe this is more of a bad request?
tinnou
reviewed
May 9, 2024
graphql-dgs/src/main/kotlin/com/netflix/graphql/dgs/internal/GraphQLJavaErrorInstrumentation.kt
Show resolved
Hide resolved
tinnou
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
This makes the error consistent with our other error handling in the DGS framework where we emit TypedGraphQlErrors. Previously, we were emitting the validation error from graphql-java directly.