Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

fix compatibility with 1.x #841

Merged
merged 1 commit into from
Oct 26, 2018
Merged

fix compatibility with 1.x #841

merged 1 commit into from
Oct 26, 2018

Conversation

apanicker-nflx
Copy link
Collaborator

No description provided.

@apanicker-nflx apanicker-nflx merged commit 2984618 into dev Oct 26, 2018
@apanicker-nflx apanicker-nflx deleted the compatibility_fix branch October 26, 2018 00:13
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1966

  • 2 of 16 (12.5%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 63.074%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/src/main/java/com/netflix/conductor/common/metadata/workflow/WorkflowTask.java 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
grpc-server/src/main/java/com/netflix/conductor/grpc/server/GRPCServer.java 2 85.71%
core/src/main/java/com/netflix/conductor/service/Lifecycle.java 3 30.0%
Totals Coverage Status
Change from base Build 1946: -0.05%
Covered Lines: 7034
Relevant Lines: 11152

💛 - Coveralls

@codecov
Copy link

codecov bot commented Oct 26, 2018

Codecov Report

Merging #841 into dev will decrease coverage by 0.04%.
The diff coverage is 12.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #841      +/-   ##
============================================
- Coverage     58.56%   58.51%   -0.05%     
  Complexity     2213     2213              
============================================
  Files           207      207              
  Lines         11138    11152      +14     
  Branches       1056     1056              
============================================
+ Hits           6523     6526       +3     
- Misses         4111     4122      +11     
  Partials        504      504
Impacted Files Coverage Δ Complexity Δ
...nductor/common/metadata/workflow/WorkflowTask.java 68.49% <0%> (-4.68%) 81 <0> (ø)
...ava/com/netflix/conductor/common/run/Workflow.java 70.7% <100%> (ø) 56 <2> (ø) ⬇️
.../java/com/netflix/conductor/service/Lifecycle.java 30% <0%> (-30%) 2% <0%> (-1%)
.../com/netflix/conductor/grpc/server/GRPCServer.java 78.57% <0%> (-14.29%) 4% <0%> (ø)
...om/netflix/conductor/grpc/AbstractProtoMapper.java 38.91% <0%> (+0.12%) 54% <0%> (ø) ⬇️
...in/java/com/netflix/conductor/jedis/JedisMock.java 10.46% <0%> (+0.48%) 22% <0%> (ø) ⬇️
...n/java/com/netflix/conductor/metrics/Monitors.java 75.55% <0%> (+2.22%) 34% <0%> (+1%) ⬆️
...flix/conductor/core/execution/WorkflowSweeper.java 69.64% <0%> (+5.35%) 8% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26cfd71...adbcb8a. Read the comment docs.

long-64 pushed a commit to long-64/conductor that referenced this pull request Oct 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants