This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Optimizing reading from datastore during WorkflowSweeper#sweep #3816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Young-Zen
reviewed
Oct 19, 2023
core/src/main/java/com/netflix/conductor/core/reconciliation/WorkflowSweeper.java
Show resolved
Hide resolved
|
🥺 please review |
|
Started a discussion to give a bit more details for this change - #3841 |
v1r3n
approved these changes
Nov 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
Added a dependency to executorDaoFacade in WorkflowSweeper.
Added overloaded method in WorkflowRepairService - verifyAndRepairWorkflowTasks(WorkflowModel workflow)
Added overloaded method in WorkflowExecutor - decideWithLock(WorkflowModel workflow)
WorkflowSweeper now calls executorDaoFacade to get the workflow once and then passes is to the overloaded methods.
Describe the new behavior from this PR, and why it's needed
The new behaviour reduces the stress on the datastore during heavy loads. We have observed absurd loads on our redis instance comming from constant sweeping from the workflowSweeper ( more than 10GBps )