Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

Upgrading OSS libraries with known open CVEs #3778

Merged
merged 7 commits into from
Nov 25, 2023

Conversation

scottcarter87
Copy link
Contributor

@scottcarter87 scottcarter87 commented Sep 20, 2023

Pull Request type

  • [*] Build related changes (Please run ./gradlew generateLock saveLock to refresh dependencies)

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

Upgrading OSS libraries used within conductor that have known CVEs. The vulnerable packages were detected by our OSSPI container scans and needed to be fixed in order for us to remain compliant and able to use conductor. This PR applies the fixes that we needed to ensure that Conductor could be deployed within our environment.

@pkrasko
Copy link

pkrasko commented Sep 20, 2023

+1

@VerstraeteBert
Copy link
Contributor

Need this as well.

@ivakoleva
Copy link

+1
Provide the list of CVEs fixed, it is helpful to build the release notes accordingly.

@v1r3n
Copy link
Contributor

v1r3n commented Sep 28, 2023

@scottcarter87 can you take a look at the failing build?

@scottcarter87
Copy link
Contributor Author

@v1r3n I get the same error locally. Taking a look.

@scottcarter87
Copy link
Contributor Author

scottcarter87 commented Oct 4, 2023

Still getting a weird error locally on java-sdk for one test. Not sure if its my local setup (M2 Mac) which also has issues with the version of test containers used or if there is an additional test issue now. The first CI failure was resolved by using a newer protobuf version.

WorkflowCreationTests.verifyInlineWorkflowExecution()

5050 [Test worker] WARN  com.netflix.conductor.client.http.ClientBase [] - Unable to invoke Conductor API with uri: http://localhost:8080/api/metadata/taskdefs/get_user_info, unexpected response from server: statusCode=404, responseBody='{"status":404,"message":"No such taskType found by name: get_user_info","instance":"cartersc7MR71.vmware.com","retryable":false}'.
5050 [ForkJoinPool.commonPool-worker-8] WARN  com.netflix.conductor.client.http.ClientBase [] - Unable to invoke Conductor API with uri: http://localhost:8080/api/metadata/taskdefs/fork_gen, unexpected response from server: statusCode=404, responseBody='{"status":404,"message":"No such taskType found by name: fork_gen","instance":"cartersc7MR71.vmware.com","retryable":false}'.
5050 [ForkJoinPool.commonPool-worker-3] WARN  com.netflix.conductor.client.http.ClientBase [] - Unable to invoke Conductor API with uri: http://localhost:8080/api/metadata/taskdefs/task2, unexpected response from server: statusCode=404, responseBody='{"status":404,"message":"No such taskType found by name: task2","instance":"cartersc7MR71.vmware.com","retryable":false}'.
5125 [pool-8-thread-19] WARN  com.netflix.config.sources.URLConfigurationSource [] - No URLs will be polled as dynamic configuration sources.
5125 [pool-8-thread-19] INFO  com.netflix.config.sources.URLConfigurationSource [] - To enable URLs as dynamic configuration sources, define System property archaius.configurationSource.additionalUrls or make config.properties available on classpath.
5130 [pool-8-thread-19] INFO  com.netflix.config.DynamicPropertyFactory [] - DynamicPropertyFactory is initialized with configuration sources: com.netflix.config.ConcurrentCompositeConfiguration@5328f8ca

Cannot invoke "javax.script.ScriptEngine.createBindings()" because "com.netflix.conductor.core.events.ScriptEvaluator.engine" is null
Expected :COMPLETED
Actual   :FAILED

@scottcarter87
Copy link
Contributor Author

@v1r3n All of the build issues have been resolved and I get a clean build locally. Please run the build again if you could.

@scottcarter87
Copy link
Contributor Author

+1 Provide the list of CVEs fixed, it is helpful to build the release notes accordingly.

Added to the main description

@ivakoleva
Copy link

What is left to do in order to apply the improvement?

@wildMythicWest
Copy link
Contributor

+1

@scottcarter87
Copy link
Contributor Author

Updated with the latest code from main

@scottcarter87
Copy link
Contributor Author

@v1r3n any specific reason this is still sitting un-merged?

@v1r3n v1r3n merged commit 52dbb92 into Netflix:main Nov 25, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants