Skip to content
This repository has been archived by the owner on Dec 13, 2023. It is now read-only.

New workflow metadata endpoint #3670

Merged

Conversation

alexmay48
Copy link
Contributor

@alexmay48 alexmay48 commented Jun 26, 2023

Pull Request type

  • Feature

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

Adds a new endpoint that allows grabbing all workflows, but only the latest definitions.

Describe the new behavior from this PR, and why it's needed
Issue #3642
It provides an endpoint that grabs all workflow definitions, but only their latest versions. This will dramatically decrease payload size when searching all workflows.

Alternatives considered

Describe alternative implementation you have considered

@alexmay48 alexmay48 changed the title Alexmay48/new workflow metadata endpoint New workflow metadata endpoint Jun 26, 2023
@v1r3n v1r3n self-requested a review June 30, 2023 16:44
@v1r3n
Copy link
Contributor

v1r3n commented Jun 30, 2023

Hi @alexmay48 looks good, but you also want to update other DAOs here or else it will break the build:
https://github.com/Netflix/conductor-community/tree/main/persistence

Another suggestion: Also add this method to the conductor-client.

@alexmay48
Copy link
Contributor Author

@v1r3n To make the fixes to the DAOs in https://github.com/Netflix/conductor-community/tree/main/persistence, won't I need this PR to go through to implement the interface for this? Or is there some process to use a snapshot of the conductor repo for development to implement the MetadataDAO interface for the conductor-community repo? It seems like there is a circular dependency that doesn't seem great for development. Let me know if my question isn't clear. Thanks.

@v1r3n
Copy link
Contributor

v1r3n commented Jul 2, 2023

@v1r3n To make the fixes to the DAOs in https://github.com/Netflix/conductor-community/tree/main/persistence, won't I need this PR to go through to implement the interface for this? Or is there some process to use a snapshot of the conductor repo for development to implement the MetadataDAO interface for the conductor-community repo? It seems like there is a circular dependency that doesn't seem great for development. Let me know if my question isn't clear. Thanks.

You can use your branch/fork with the changes, publish them to local maven repository gradlew publishToMavenLocal and use that version (you can run gradlew properties and check for Inferred project: conductor, version: to find the version.

With that you will be able to make the changes.

@alexmay48
Copy link
Contributor Author

@v1r3n To make the fixes to the DAOs in https://github.com/Netflix/conductor-community/tree/main/persistence, won't I need this PR to go through to implement the interface for this? Or is there some process to use a snapshot of the conductor repo for development to implement the MetadataDAO interface for the conductor-community repo? It seems like there is a circular dependency that doesn't seem great for development. Let me know if my question isn't clear. Thanks.

You can use your branch/fork with the changes, publish them to local maven repository gradlew publishToMavenLocal and use that version (you can run gradlew properties and check for Inferred project: conductor, version: to find the version.

With that you will be able to make the changes.

Thanks for the help, @v1r3n. Here are the changes to the conductor-community repo: Netflix/conductor-community#240. Let me know if I'm not doing the changes right for the PR for the community repo. Thanks.

@v1r3n v1r3n merged commit f013a53 into Netflix:main Jul 8, 2023
@alexmay48 alexmay48 deleted the alexmay48/new-workflow-metadata-endpoint branch July 10, 2023 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants