This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
[#3442] fix: can't click task card to open the right panel while using FireFox #3444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arketec
reviewed
Jan 13, 2023
| */ | ||
| getTaskRef = (e) => { | ||
| const isFirefox = navigator.userAgent.toLowerCase().indexOf("firefox") > -1; | ||
| if (isFirefox) { |
There was a problem hiding this comment.
This fix should also work in the latest version of Chrome:
from the latest console in chrome:
This was tested at the breakpoint at line 342 in the current src (355 in this commit)
referring to the workflow from my original question:
#3442
ceisen1
reviewed
Jan 20, 2023
| handleClick = (e) => { | ||
| const taskRef = e.path[1].id || e.path[2].id; // could be 2 layers down | ||
| const taskRef = this.getTaskRef(e); |
There was a problem hiding this comment.
I believe this could be made simpler with event.composedPath(). Chrome recommends updating to this for the now deprecated event.path API https://chromestatus.com/feature/5726124632965120.
It also seems to be compatible with all major browsers https://developer.mozilla.org/en-US/docs/Web/API/Event/composedPath#browser_compatibility
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
Issue #3442
User can't click on task at flow diagram to open the right side panel while using FireFox browser.
Screen.Recording.2023-01-13.at.15.41.41.mov