This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Fail workflow if input to dynamic fork join task is invalid #3273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apanicker-nflx
approved these changes
Oct 5, 2022
| } catch (Exception e) { | ||
| String reason = | ||
| String.format( | ||
| "Dynamic tasks could not be created due to invalid task input: %s ", |
There was a problem hiding this comment.
nit: Since, DYNAMIC is a task type already, this would probably read better as Tasks could not be dynamically forked due to invalid input: %s
aravindanr
approved these changes
Oct 6, 2022
| @@ -61,4 +61,8 @@ abstract class AbstractSpecification extends Specification { | |||
|
|
|||
| workflowExecutor.startWorkflow(input) | |||
| } | |||
|
|
|||
| protected String startWorkflow(StartWorkflowInput startWorkflowInput) { | |||
There was a problem hiding this comment.
nit: instead of this method in the base class, the sub-classes can directly call workflowExecutor.startWorkflow(). It adds a layer of indirection, which is not necessary.
jxu-nflx
force-pushed
the
bugfix/invalid_input_dynamic_fork_join
branch
from
6472c25 to
3ef90f9
Compare
pmchung
pushed a commit
to routific/conductor
that referenced
this pull request
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Fix the issue that uncaught exception thrown when the task input of FORK_JOIN_DYNAMIC is invalid, and task seem to be stuck. Also startWorkflow will fail with 500 in this case if FORK_JOIN_DYNAMIC task is synchronous evaluated when workflow starts.
Describe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered