This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Bug 2678- tcp protocol support for es6 #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deoramanas
changed the title
added 3 commits
January 10, 2022 12:48
|
@apanicker-nflx Shared the PR |
aravindanr
suggested changes
Jan 19, 2022
es6-persistence/src/main/java/com/netflix/conductor/es6/config/ElasticSearchProperties.java
Outdated
Show resolved
Hide resolved
es6-persistence/src/main/java/com/netflix/conductor/es6/config/ElasticSearchProperties.java
Outdated
Show resolved
Hide resolved
|
Please run |
…V6Configuration.java 2. Removed newly introduced getURL() and used existing getUrl() of ElasticSearchProperties.java class 3. Used spotlessApply to fix formatting errors
Yes.. since our changes are only in es6 module, I ran -> ./gradlew :conductor-es6-persistence:spotlessApply |
|
@apanicker-nflx @aravindanr requested changes are incorporated. Let me know if there are more.. |
apanicker-nflx
approved these changes
Jan 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLockto refresh dependencies)Changes in this PR
Support for tcp protocol in es6
Describe the new behavior from this PR, and why it's needed
Issue #
#2678
Alternatives considered
Describe alternative implementation you have considered